Add testTruncateTable in BaseConnectorSmokeTest #17409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
delta-lake
ebyhr
approved these changes
May 9, 2023
ebyhr
added
the
no-release-notes
ebyhr
force-pushed
the
add-testTruncateTable
branch
from
0100ada to
2d045ff
Compare
ebyhr
reviewed
May 9, 2023
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
Member
|
/test-with-secrets sha=2d045ffb397ee0bbb10de9fbafc36180e570e819 |
krvikash
force-pushed
the
add-testTruncateTable
branch
2 times, most recently
from
87ed2e0 to
6151d39
Compare
findepi
approved these changes
May 10, 2023
Member
There was a problem hiding this comment.
do try (TestTable table once, before checking hasBehavior
Contributor
Author
There was a problem hiding this comment.
try (TestTable table will fail when the connector doesn't support both TRUNCATE & CREATE TABLE AS SELECT statements. Changed it to.
if (!hasBehavior(SUPPORTS_TRUNCATE)) {
assertQueryFails("TRUNCATE TABLE nation", "This connector does not support truncating tables");
}
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
|
The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/4932226217 |
krvikash
force-pushed
the
add-testTruncateTable
branch
from
6151d39 to
c90bdde
Compare
Contributor
Author
|
resolved conflicts |
krvikash
force-pushed
the
add-testTruncateTable
branch
from
c90bdde to
84c3c3a
Compare
Member
|
/test-with-secrets sha=84c3c3aa435283079a56cfb38e6c29412b2d6a05 |
Member
|
I can't find the relevant CI job with secrets. Let me rerun. |
Member
|
/test-with-secrets sha=84c3c3aa435283079a56cfb38e6c29412b2d6a05 |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.