Add table functions to function list#17395
Conversation
There was a problem hiding this comment.
or remove () here ... and instead do a
sequence (table function)
or something like that?
There was a problem hiding this comment.
When () is removed, sequence TF renders different than exclude_columns TF.
I think we should keep (), and additionally add a note like (table function) for disambiguation.
So, it would be:
- :ref:sequence ( ) <sequence_table_function> (table function)
381ebbb to
0704d78
Compare
There was a problem hiding this comment.
I feel like the best fix for this is renaming one of the functions - having two different functions with the same name seems problematic in general.
There was a problem hiding this comment.
Scalar and table functions are in different namespaces, so we shouldn’t rename them just because they get mixed up in this list.
An alternative would be to have a separate list for table functions, or add a disambiguation parenthetical.
There was a problem hiding this comment.
Thats what I suggested in another comment .. and I think this is better than having the same wording twice with different links
sequencce
sequence (table function)
and only add that for table functions.. otherwise we end up with lots of (scalar function)
or we could do
sequence (scalar function, table function)
and link the ones in brackets.. but personally I think that is worse than having two lines..
05c4f36 to
acd0bb0
Compare
acd0bb0 to
4976e0e
Compare
|
I think I most prefer @kasiafi's suggestion here - |
Description
Additional docs for #16716
Release notes
(x) This is not user-visible or docs only and no release notes are required.