Support table comment for redshift connector#17372
Merged
ebyhr merged 1 commit intotrinodb:masterfrom Jul 3, 2023
sahoss:master
Merged
Support table comment for redshift connector#17372ebyhr merged 1 commit intotrinodb:masterfrom sahoss:master
ebyhr merged 1 commit intotrinodb:masterfrom
sahoss:master
Conversation
Contributor
Author
|
@chenjian2664 can you please take a look at this change request? |
ebyhr
reviewed
May 7, 2023
plugin/trino-redshift/src/main/java/io/trino/plugin/redshift/RedshiftClient.java
Outdated
Show resolved
Hide resolved
plugin/trino-redshift/src/main/java/io/trino/plugin/redshift/RedshiftClient.java
Outdated
Show resolved
Hide resolved
plugin/trino-redshift/src/test/java/io/trino/plugin/redshift/TestRedshiftConnectorTest.java
Outdated
Show resolved
Hide resolved
chenjian2664
approved these changes
May 9, 2023
Contributor
Author
|
was having a busy week. i ll address the comments in this weekend. thanks for your reviews |
Contributor
Author
|
@ebyhr @chenjian2664 do take a look here. the comments are addressed. |
Contributor
Author
|
@ebyhr @chenjian2664 wondering if you could take a look at this pr? |
Member
|
Running CI with secrets at #18112 |
ebyhr
approved these changes
Jul 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix #16900
Release notes
(x) Release notes are required, with the following suggested text: