Skip to content

Fix TestRedshiftConnectorTest TestingConnectorBehavior #17361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix TestRedshiftConnectorTest TestingConnectorBehavior #17361

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions plugin/trino-redshift/src/test/java/io/trino/plugin/redshift/TestRedshiftConnectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,11 +66,15 @@ protected QueryRunner createQueryRunner()
protected boolean hasBehavior(TestingConnectorBehavior connectorBehavior)
{
switch (connectorBehavior) {
case SUPPORTS_COMMENT_ON_COLUMN:
return true;

case SUPPORTS_COMMENT_ON_TABLE:
case SUPPORTS_CREATE_TABLE_WITH_TABLE_COMMENT:
case SUPPORTS_CREATE_TABLE_WITH_COLUMN_COMMENT:
return false;

case SUPPORTS_ADD_COLUMN_NOT_NULL_CONSTRAINT:
case SUPPORTS_ADD_COLUMN_WITH_COMMENT:
case SUPPORTS_SET_COLUMN_TYPE:
return false;
Expand All @@ -82,10 +86,10 @@ protected boolean hasBehavior(TestingConnectorBehavior connectorBehavior)
case SUPPORTS_RENAME_TABLE_ACROSS_SCHEMAS:
return false;

case SUPPORTS_AGGREGATION_PUSHDOWN_STDDEV:
case SUPPORTS_AGGREGATION_PUSHDOWN_VARIANCE:
case SUPPORTS_AGGREGATION_PUSHDOWN_COUNT_DISTINCT:
return true;
case SUPPORTS_AGGREGATION_PUSHDOWN_COVARIANCE:
Copy link
Contributor

@findinpath findinpath May 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

affected tests in BCT:

  • testCovarianceAggregationPushdown
  • testCorrAggregationPushdown
  • testRegrAggregationPushdown

case SUPPORTS_AGGREGATION_PUSHDOWN_CORRELATION:
case SUPPORTS_AGGREGATION_PUSHDOWN_REGRESSION:
return false;

case SUPPORTS_JOIN_PUSHDOWN:
case SUPPORTS_JOIN_PUSHDOWN_WITH_VARCHAR_EQUALITY:
Expand Down