Skip to content

Remove unused HiveCoercionRecordCursor#17306

Merged
dain merged 1 commit intotrinodb:masterfrom
dain:remove-hive-coercion-record-cursor
May 1, 2023
Merged

Remove unused HiveCoercionRecordCursor#17306
dain merged 1 commit intotrinodb:masterfrom
dain:remove-hive-coercion-record-cursor

Conversation

@dain
Copy link
Member

@dain dain commented Apr 30, 2023

All Hive record cursors extend GenericHiveRecordCursor which does not need this wrapper. Additionally, this wrapper has may bugs that result in null pointer exceptions if used.

Release notes

(x) This is not user-visible or docs only and no release notes are required.

@dain dain requested a review from electrum April 30, 2023 21:02
@cla-bot cla-bot bot added the cla-signed label Apr 30, 2023
@github-actions github-actions bot added hive Hive connector tests:hive labels Apr 30, 2023
All Hive record cursors extend GenericHiveRecordCursor which does not
need this wrapper. Additionally, this wrapper has may bugs that result
in null pointer exceptions if used.
@dain dain force-pushed the remove-hive-coercion-record-cursor branch from 57192bb to 4166440 Compare April 30, 2023 23:38
@dain dain merged commit e19bf90 into trinodb:master May 1, 2023
@dain dain deleted the remove-hive-coercion-record-cursor branch May 1, 2023 04:03
@github-actions github-actions bot added this to the 416 milestone May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed hive Hive connector

Development

Successfully merging this pull request may close these issues.

2 participants