Skip to content

Remove deprecated ConnectorMetadata.getSchemaTableName #17267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
findepi wants to merge 1 commit into from
Closed

Remove deprecated ConnectorMetadata.getSchemaTableName #17267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions core/trino-main/src/main/java/io/trino/tracing/TracingConnectorMetadata.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,16 +216,6 @@ public Optional<ConnectorPartitioningHandle> getCommonPartitioningHandle(Connect
}
}

@SuppressWarnings("deprecation")
@Override
public SchemaTableName getSchemaTableName(ConnectorSession session, ConnectorTableHandle table)
{
Span span = startSpan("getSchemaTableName", table);
try (var ignored = scopedSpan(span)) {
return delegate.getSchemaTableName(session, table);
}
}

@Override
public ConnectorTableSchema getTableSchema(ConnectorSession session, ConnectorTableHandle table)
{
Expand Down
12 changes: 0 additions & 12 deletions core/trino-spi/src/main/java/io/trino/spi/connector/ConnectorMetadata.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,18 +217,6 @@ default Optional<ConnectorPartitioningHandle> getCommonPartitioningHandle(Connec
return Optional.empty();
}

/**
* Return schema table name for the specified table handle.
* This method is useful when requiring only {@link SchemaTableName} without other objects.
*
* @throws RuntimeException if table handle is no longer valid
*/
@Deprecated // ... and optimized implementations already removed
default SchemaTableName getSchemaTableName(ConnectorSession session, ConnectorTableHandle table)
{
return getTableSchema(session, table).getTable();
}

/**
* Return table schema definition for the specified table handle.
* This method is useful when getting full table metadata is expensive.
Expand Down
8 changes: 0 additions & 8 deletions ...lkit/src/main/java/io/trino/plugin/base/classloader/ClassLoaderSafeConnectorMetadata.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,14 +249,6 @@ public ConnectorTableSchema getTableSchema(ConnectorSession session, ConnectorTa
}
}

@Override
public SchemaTableName getSchemaTableName(ConnectorSession session, ConnectorTableHandle table)
{
try (ThreadContextClassLoader ignored = new ThreadContextClassLoader(classLoader)) {
return delegate.getSchemaTableName(session, table);
}
}

@Override
public ConnectorTableMetadata getTableMetadata(ConnectorSession session, ConnectorTableHandle table)
{
Expand Down