Skip to content

Reject property names with dot #17241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
findepi merged 4 commits into from
Apr 28, 2023
Merged

Reject property names with dot #17241

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7878675
Fix typo in Delta session property name
findepi Apr 26, 2023
f51fd08
Reject property names with dot
findepi Apr 26, 2023
1cfaac2
Rename test helper classes to indicate they are not tests
findepi Apr 26, 2023
8975aad
Test BigQuery plugin initialization
findepi Apr 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/trino-spi/src/main/java/io/trino/spi/session/PropertyMetadata.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ public PropertyMetadata(
requireNonNull(decoder, "decoder is null");
requireNonNull(encoder, "encoder is null");

if (name.isEmpty() || !name.trim().toLowerCase(ENGLISH).equals(name)) {
if (name.isEmpty() || !name.trim().toLowerCase(ENGLISH).equals(name) || name.contains(".")) {
throw new IllegalArgumentException(format("Invalid property name '%s'", name));
}
if (description.isEmpty() || !description.trim().equals(description)) {
Expand Down
2 changes: 1 addition & 1 deletion .../trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeSessionProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ public final class DeltaLakeSessionProperties
public static final String VACUUM_MIN_RETENTION = "vacuum_min_retention";
private static final String HIVE_CATALOG_NAME = "hive_catalog_name";
private static final String PARQUET_MAX_READ_BLOCK_SIZE = "parquet_max_read_block_size";
private static final String PARQUET_MAX_READ_BLOCK_ROW_COUNT = "parquet.max_read_block_row_count";
private static final String PARQUET_MAX_READ_BLOCK_ROW_COUNT = "parquet_max_read_block_row_count";
private static final String PARQUET_USE_COLUMN_INDEX = "parquet_use_column_index";
private static final String PARQUET_OPTIMIZED_READER_ENABLED = "parquet_optimized_reader_enabled";
private static final String PARQUET_OPTIMIZED_NESTED_READER_ENABLED = "parquet_optimized_nested_reader_enabled";
Expand Down