Add initial Azure TrinoFileSystem#17237
Merged
dain merged 2 commits intotrinodb:masterfrom Jun 6, 2023
Merged
Conversation
electrum
approved these changes
May 31, 2023
lib/trino-filesystem-azure/src/main/java/io/trino/filesystem/azure/AzureAuthAccessKey.java
Outdated
Show resolved
Hide resolved
...trino-filesystem-azure/src/main/java/io/trino/filesystem/azure/AzureAuthAccessKeyConfig.java
Outdated
Show resolved
Hide resolved
...no-filesystem-azure/src/test/java/io/trino/filesystem/azure/AbstractTestAzureFileSystem.java
Outdated
Show resolved
Hide resolved
...no-filesystem-azure/src/test/java/io/trino/filesystem/azure/AbstractTestAzureFileSystem.java
Outdated
Show resolved
Hide resolved
lib/trino-filesystem-azure/src/test/java/io/trino/filesystem/azure/TestAzureUri.java
Outdated
Show resolved
Hide resolved
lib/trino-filesystem-azure/src/test/java/io/trino/filesystem/azure/TestAzureUri.java
Outdated
Show resolved
Hide resolved
lib/trino-filesystem/src/test/java/io/trino/filesystem/AbstractTestTrinoFileSystem.java
Outdated
Show resolved
Hide resolved
dain
commented
Jun 1, 2023
Member
Author
dain
left a comment
dain
left a comment
There was a problem hiding this comment.
I rebased and updated the code to the new APIs, and applied the comments. I will wait until the S3 code lands, as it has more tests, and then squash and merge this.
lib/trino-filesystem-azure/src/main/java/io/trino/filesystem/azure/AzureAuthOAuthConfig.java
Outdated
Show resolved
Hide resolved
lib/trino-filesystem-azure/src/main/java/io/trino/filesystem/azure/AzureFileSystemFactory.java
Outdated
Show resolved
Hide resolved
Member
Author
There was a problem hiding this comment.
I hacked in something in the last commit, let me know what you think
electrum
reviewed
Jun 2, 2023
lib/trino-filesystem-azure/src/main/java/io/trino/filesystem/azure/AzureOutputStream.java
Outdated
Show resolved
Hide resolved
electrum
reviewed
Jun 2, 2023
lib/trino-filesystem-azure/src/main/java/io/trino/filesystem/azure/AzureOutputStream.java
Outdated
Show resolved
Hide resolved
electrum
reviewed
Jun 2, 2023
lib/trino-filesystem-azure/src/main/java/io/trino/filesystem/azure/AzureLocation.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a starting implementation of TrinoFileSystem for Azure which supports Blob and Gen2 without or without hierarchical namespace enabled. The tests only cover access key authentication, and will need secrets for the 3 file system implementations. Also, the Guice modules have not been tested.
This is part of #15921
Release notes
(X) This is not user-visible or docs only and no release notes are required.