Merged
Conversation
ebyhr
added
the
no-release-notes
chenjian2664
approved these changes
Apr 26, 2023
|
|
||
| if (bucketProperty.isPresent() && getAvroSchemaLiteral(tableMetadata.getProperties()) != null) { | ||
| throw new TrinoException(NOT_SUPPORTED, "Bucketing/Partitioning columns not spported when Avro schema literal is set"); | ||
| throw new TrinoException(NOT_SUPPORTED, "Bucketing/Partitioning columns not supported when Avro schema literal is set"); |
Contributor
There was a problem hiding this comment.
Bucketing/Partitioning columns are not supported when Avro schema literal is set ?
Member
There was a problem hiding this comment.
yes, but also this existing class has a mixture of both XXX not supported and XXX is/are not supported. Feel welcome to introduce some consistency/logic in a fresh PR.
findinpath
approved these changes
May 3, 2023
hashhar
approved these changes
May 3, 2023
|
|
||
| if (bucketProperty.isPresent() && getAvroSchemaLiteral(tableMetadata.getProperties()) != null) { | ||
| throw new TrinoException(NOT_SUPPORTED, "Bucketing/Partitioning columns not spported when Avro schema literal is set"); | ||
| throw new TrinoException(NOT_SUPPORTED, "Bucketing/Partitioning columns not supported when Avro schema literal is set"); |
Member
There was a problem hiding this comment.
yes, but also this existing class has a mixture of both XXX not supported and XXX is/are not supported. Feel welcome to introduce some consistency/logic in a fresh PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix typo in HiveMetadata. There's no same typo
spportedin this repository.Release notes
(x) This is not user-visible or docs only and no release notes are required.