Skip to content

Suppress existent namespace error in AccumuloClient constructor #17204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hashhar merged 1 commit into from
Apr 24, 2023
Merged

Suppress existent namespace error in AccumuloClient constructor #17204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion plugin/trino-accumulo/src/main/java/io/trino/plugin/accumulo/AccumuloClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,14 @@ public AccumuloClient(

// The default namespace is created in ZooKeeperMetadataManager's constructor
if (!tableManager.namespaceExists(DEFAULT_SCHEMA)) {
tableManager.createNamespace(DEFAULT_SCHEMA);
try {
tableManager.createNamespace(DEFAULT_SCHEMA);
}
catch (TrinoException e) {
if (!e.getErrorCode().equals(ALREADY_EXISTS.toErrorCode())) {
throw e;
}
}
}
}

Expand Down
6 changes: 5 additions & 1 deletion plugin/trino-accumulo/src/main/java/io/trino/plugin/accumulo/AccumuloTableManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
import static io.trino.plugin.accumulo.AccumuloErrorCode.ACCUMULO_TABLE_DNE;
import static io.trino.plugin.accumulo.AccumuloErrorCode.ACCUMULO_TABLE_EXISTS;
import static io.trino.plugin.accumulo.AccumuloErrorCode.UNEXPECTED_ACCUMULO_ERROR;
import static io.trino.spi.StandardErrorCode.ALREADY_EXISTS;
import static java.util.Objects.requireNonNull;

/**
Expand All @@ -58,7 +59,10 @@ public void createNamespace(String schema)
try {
connector.namespaceOperations().create(schema);
}
catch (AccumuloException | AccumuloSecurityException | NamespaceExistsException e) {
catch (NamespaceExistsException e) {
throw new TrinoException(ALREADY_EXISTS, "Namespace already exists: " + schema, e);
}
catch (AccumuloException | AccumuloSecurityException e) {
throw new TrinoException(UNEXPECTED_ACCUMULO_ERROR, "Failed to create Accumulo namespace: " + schema, e);
}
}
Expand Down