Skip to content

Use enhanced routine when dropping Delta tables backed by AWS Glue on Databricks #17197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ebyhr merged 2 commits into from
Apr 25, 2023
Merged

Use enhanced routine when dropping Delta tables backed by AWS Glue on Databricks #17197

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f4540a
Use enhanced switch
findinpath Apr 24, 2023
1af45dd
Retry dropping delta table backed by AWS Glue on Databricks
findinpath Apr 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 19 additions & 25 deletions ...s/src/main/java/io/trino/tests/product/deltalake/TestDeltaLakeDropTableCompatibility.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,40 +87,34 @@ private void testDropTableAccuracy(Engine creator, Engine dropper, boolean expli
: Optional.empty();

switch (creator) {
case TRINO:
onTrino().executeQuery(format("CREATE SCHEMA delta.%s WITH (location = '%s')", schemaName, schemaLocation));
break;
case DELTA:
onDelta().executeQuery(format("CREATE SCHEMA %s LOCATION \"%s\"", schemaName, schemaLocation));
break;
default:
throw new UnsupportedOperationException("Unsupported engine: " + creator);
case TRINO -> onTrino().executeQuery(format("CREATE SCHEMA delta.%s WITH (location = '%s')", schemaName, schemaLocation));
case DELTA -> onDelta().executeQuery(format("CREATE SCHEMA %s LOCATION \"%s\"", schemaName, schemaLocation));
default -> throw new UnsupportedOperationException("Unsupported engine: " + creator);
}
try {
onTrino().executeQuery("USE delta." + schemaName);
switch (creator) {
case TRINO:
onTrino().executeQuery(format(
"CREATE TABLE %s.%s (a, b) %s AS VALUES (1, 2), (2, 3), (3, 4)",
schemaName,
tableName,
tableLocation.map(location -> "WITH (location = '" + location + "')").orElse("")));
break;
case DELTA:
onDelta().executeQuery(format(
"CREATE TABLE %s.%s USING DELTA %s AS VALUES (1, 2), (2, 3), (3, 4)",
schemaName,
tableName,
tableLocation.map(location -> "LOCATION \"" + location + "\"").orElse("")));
break;
default:
throw new UnsupportedOperationException("Unsupported engine: " + creator);
case TRINO -> onTrino().executeQuery(format(
"CREATE TABLE %s.%s (a, b) %s AS VALUES (1, 2), (2, 3), (3, 4)",
schemaName,
tableName,
tableLocation.map(location -> "WITH (location = '" + location + "')").orElse("")));
case DELTA -> onDelta().executeQuery(format(
"CREATE TABLE %s.%s USING DELTA %s AS VALUES (1, 2), (2, 3), (3, 4)",
schemaName,
tableName,
tableLocation.map(location -> "LOCATION \"" + location + "\"").orElse("")));
default -> throw new UnsupportedOperationException("Unsupported engine: " + creator);
}

ObjectListing tableFiles = s3.listObjects(bucketName, "databricks-compatibility-test-" + schemaName + "/" + tableName);
assertThat(tableFiles.getObjectSummaries()).isNotEmpty();

dropper.queryExecutor().executeQuery("DROP TABLE " + schemaName + "." + tableName);
switch (dropper) {
case DELTA -> dropDeltaTableWithRetry(schemaName + "." + tableName);
case TRINO -> onTrino().executeQuery("DROP TABLE " + schemaName + "." + tableName);
default -> throw new UnsupportedOperationException("Unsupported engine: " + dropper);
}
tableFiles = s3.listObjects(bucketName, "databricks-compatibility-test-" + schemaName + "/" + tableName);
if (explicitLocation) {
assertThat(tableFiles.getObjectSummaries()).isNotEmpty();
Expand Down