Remove flaky race-prone assertions in TestDriver#17144
Merged
pettyjamesm merged 1 commit intotrinodb:masterfrom Apr 20, 2023
Merged
Remove flaky race-prone assertions in TestDriver#17144pettyjamesm merged 1 commit intotrinodb:masterfrom
pettyjamesm merged 1 commit intotrinodb:masterfrom
Conversation
Avoids asserting that driver destroyed future is not complete in TestDriver tests that do not block on BrokenOperator#close(). Otherwise the assertion is subject to a simple race condition causing sporadic test failures.
martint
approved these changes
Apr 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Avoids asserting that driver destroyed future is not complete in
TestDrivertests that do not block onBrokenOperator#close(). Otherwise the assertion is subject to a simple race condition causing sporadic test failures.Fixes #16925
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: