Be more conservative when turning off partial aggregation#17143
Merged
sopel39 merged 5 commits intotrinodb:masterfrom Apr 25, 2023
Merged
Be more conservative when turning off partial aggregation#17143sopel39 merged 5 commits intotrinodb:masterfrom
sopel39 merged 5 commits intotrinodb:masterfrom
Conversation
Page with 0 rows is indistinguishable from not processing a page.
lukasz-stec
reviewed
Apr 20, 2023
Member
lukasz-stec
left a comment
lukasz-stec
left a comment
There was a problem hiding this comment.
a few comments.
Generally looks good
...o-main/src/main/java/io/trino/operator/aggregation/partial/PartialAggregationController.java
Outdated
Show resolved
Hide resolved
...o-main/src/main/java/io/trino/operator/aggregation/partial/PartialAggregationController.java
Outdated
Show resolved
Hide resolved
...o-main/src/main/java/io/trino/operator/aggregation/partial/PartialAggregationController.java
Outdated
Show resolved
Hide resolved
raunaqmorarka
approved these changes
Apr 24, 2023
core/trino-main/src/main/java/io/trino/operator/HashAggregationOperator.java
Outdated
Show resolved
Hide resolved
...o-main/src/main/java/io/trino/operator/aggregation/partial/PartialAggregationController.java
Outdated
Show resolved
Hide resolved
lukasz-stec
reviewed
Apr 25, 2023
...o-main/src/main/java/io/trino/operator/aggregation/partial/PartialAggregationController.java
Outdated
Show resolved
Hide resolved
...o-main/src/main/java/io/trino/operator/aggregation/partial/PartialAggregationController.java
Outdated
Show resolved
Hide resolved
...o-main/src/main/java/io/trino/operator/aggregation/partial/PartialAggregationController.java
Outdated
Show resolved
Hide resolved
Member
Author
|
Unpart results:
part results:
|
Partial aggregation might have better efficiency when PA buffer is fully utilized. Therefore it doesn't make sense to disable partial aggregation eagerly after small amount of input data was processed (e.g. for few small initial splits which didn't fully utilized PA buffer).
Re-enable partial aggregation periodically in case aggregation efficiency improved while data is being processed (e.g. larger splits are observed).
6 tasks
prithvip
added a commit
to prithvip/presto
that referenced
this pull request
Nov 27, 2023
When partial aggregation is not effectively reducing cardinality, instead send raw input rows directly to the final aggregation step. Port of: github.com/trinodb/trino/pull/11011 github.com/trinodb/trino/pull/17143 Co-authored-by: Lukasz Stec <lukasz.s.stec@gmail.com> Co-authored-by: Karol Sobczak <sopel39@users.noreply.github.com>
prithvip
added a commit
to prestodb/presto
that referenced
this pull request
Nov 27, 2023
When partial aggregation is not effectively reducing cardinality, instead send raw input rows directly to the final aggregation step. Port of: github.com/trinodb/trino/pull/11011 github.com/trinodb/trino/pull/17143 Co-authored-by: Lukasz Stec <lukasz.s.stec@gmail.com> Co-authored-by: Karol Sobczak <sopel39@users.noreply.github.com>
mlyublena
pushed a commit
to prestodb/presto
that referenced
this pull request
Nov 28, 2023
When partial aggregation is not effectively reducing cardinality, instead send raw input rows directly to the final aggregation step. Port of: github.com/trinodb/trino/pull/11011 github.com/trinodb/trino/pull/17143 Co-authored-by: Lukasz Stec <lukasz.s.stec@gmail.com> Co-authored-by: Karol Sobczak <sopel39@users.noreply.github.com>
kaikalur
pushed a commit
to kaikalur/presto
that referenced
this pull request
Mar 14, 2024
When partial aggregation is not effectively reducing cardinality, instead send raw input rows directly to the final aggregation step. Port of: github.com/trinodb/trino/pull/11011 github.com/trinodb/trino/pull/17143 Co-authored-by: Lukasz Stec <lukasz.s.stec@gmail.com> Co-authored-by: Karol Sobczak <sopel39@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RN
Fixes #11361