Fix SQL formatting in TestDynamicTable #17109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Member
Author
|
This is dependent on #17106 otherwise tests will fail. |
elonazoulay
force-pushed
the
fix_pinot_sql_gen
branch
from
956ac0a to
6bc9faa
Compare
hashhar
force-pushed
the
fix_pinot_sql_gen
branch
from
6bc9faa to
6808bb7
Compare
Member
|
|
elonazoulay
force-pushed
the
fix_pinot_sql_gen
branch
from
6808bb7 to
8086515
Compare
elonazoulay
force-pushed
the
fix_pinot_sql_gen
branch
from
8086515 to
5adf915
Compare
hashhar
reviewed
Apr 21, 2023
plugin/trino-pinot/src/test/java/io/trino/plugin/pinot/BasePinotConnectorSmokeTest.java
Show resolved
Hide resolved
hashhar
approved these changes
Apr 21, 2023
Member
hashhar
left a comment
hashhar
left a comment
There was a problem hiding this comment.
does the 2nd commit need to be squashed? Since the first one failed tests without it?
Member
Author
It can be, it isn't related to the failures in the first commit, it was just code cleanup since InterruptedException was never thrown (even in master). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use uppercase for SQL keywords
Additional context and related issues
Release notes
(X ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: