Skip to content

Validate nodeCount in DistributedQueryRunner #17097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
findepi merged 1 commit into from
Apr 19, 2023
Merged

Validate nodeCount in DistributedQueryRunner #17097

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions testing/trino-testing/src/main/java/io/trino/testing/DistributedQueryRunner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,10 +123,6 @@ private DistributedQueryRunner(
{
requireNonNull(defaultSession, "defaultSession is null");

if (backupCoordinatorProperties.isPresent()) {
checkArgument(nodeCount >= 2, "the nodeCount must be greater than or equal to two!");
}

setupLogging();

try {
Expand All @@ -137,7 +133,9 @@ private DistributedQueryRunner(

registerNewWorker = () -> createServer(false, extraProperties, environment, additionalModule, baseDataDir, ImmutableList.of(), ImmutableList.of());

for (int i = backupCoordinatorProperties.isEmpty() ? 1 : 2; i < nodeCount; i++) {
int coordinatorCount = backupCoordinatorProperties.isEmpty() ? 1 : 2;
checkArgument(nodeCount >= coordinatorCount, "nodeCount includes coordinator(s) count, so must be at least %s, got: %s", coordinatorCount, nodeCount);
Comment thread
hashhar marked this conversation as resolved.
for (int i = coordinatorCount; i < nodeCount; i++) {
registerNewWorker.run();
}

Expand Down