Increase TypedSet expectedSize in DynamicFilterSourceOperator#17086
Merged
raunaqmorarka merged 1 commit intotrinodb:masterfrom Apr 19, 2023
Merged
Increase TypedSet expectedSize in DynamicFilterSourceOperator#17086raunaqmorarka merged 1 commit intotrinodb:masterfrom
raunaqmorarka merged 1 commit intotrinodb:masterfrom
Conversation
Current initial size of 8 is very small and leads to unnecessary amount of rehashing Benchmark (collectionLimits) (positionsPerPage) Mode Cnt Before Score After Score Units BenchmarkDynamicFilterSourceOperator.dynamicFilterCollect 5000,0 1024 avgt 45 0.663 ± 0.133 0.257 ± 0.017 ms/op BenchmarkDynamicFilterSourceOperator.dynamicFilterCollect 50000,0 1024 avgt 45 6.420 ± 0.956 3.703 ± 0.139 ms/op BenchmarkDynamicFilterSourceOperator.dynamicFilterCollect 1000000,0 1024 avgt 45 38.821 ± 2.883 32.224 ± 1.992 ms/op
sopel39
approved these changes
Apr 18, 2023
core/trino-main/src/main/java/io/trino/operator/DynamicFilterSourceOperator.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Current initial size of 8 is very small and leads to unnecessary amount of rehashing
Additional context and related issues
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: