Skip to content

Support CREATE OR REPLACE in parser#17050

Merged
martint merged 3 commits intotrinodb:masterfrom
mdesmet:feature/create-or-replace-grammar
Jul 5, 2023
Merged

Support CREATE OR REPLACE in parser#17050
martint merged 3 commits intotrinodb:masterfrom
mdesmet:feature/create-or-replace-grammar

Conversation

@mdesmet
Copy link
Copy Markdown
Contributor

@mdesmet mdesmet commented Apr 16, 2023 •
edited
Loading

Description

Grammar changes to support CREATE OR REPLACE

Additional context and related issues

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Apr 16, 2023
@mdesmet mdesmet requested review from electrum and findepi April 16, 2023 17:31
@findepi findepi requested review from kasiafi and martint April 17, 2023 10:01
@mdesmet mdesmet self-assigned this Apr 17, 2023
@findepi
Copy link
Copy Markdown
Member

findepi commented Apr 19, 2023

LGTM. Add a check (perhaps in CreateTableTask and StatementAnalyzer) so that OR REPLACE isn't silently ignored.
The check will be removed in next PR as we continue the work.

@findepi findepi requested a review from ebyhr April 19, 2023 08:35
ebyhr
ebyhr approved these changes Apr 19, 2023
View reviewed changes
kasiafi
kasiafi reviewed Apr 19, 2023
View reviewed changes
@mdesmet mdesmet force-pushed the feature/create-or-replace-grammar branch 4 times, most recently from 8022b17 to 886f2ce Compare April 23, 2023 15:04
@mdesmet
Copy link
Copy Markdown
Contributor Author

mdesmet commented Apr 23, 2023

PTAL, I processed all remarks. I also added checks in StatementAnalyzer and CreateTableTask.

kasiafi
kasiafi reviewed Apr 25, 2023
View reviewed changes
@mdesmet mdesmet force-pushed the feature/create-or-replace-grammar branch 3 times, most recently from 2daf3eb to 6feb724 Compare April 26, 2023 08:22
kasiafi
kasiafi approved these changes Apr 28, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@kasiafi kasiafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % comments

@mdesmet mdesmet force-pushed the feature/create-or-replace-grammar branch from 6feb724 to 3c645c3 Compare April 28, 2023 12:15
martint
martint requested changes Apr 28, 2023
View reviewed changes
@mdesmet mdesmet force-pushed the feature/create-or-replace-grammar branch from 3c645c3 to 233a660 Compare April 28, 2023 20:04
@mdesmet mdesmet force-pushed the feature/create-or-replace-grammar branch 3 times, most recently from 0b6ffe3 to 7451c53 Compare May 9, 2023 14:17
kasiafi
kasiafi reviewed May 10, 2023
View reviewed changes
kasiafi
kasiafi reviewed May 10, 2023
View reviewed changes
@mdesmet mdesmet force-pushed the feature/create-or-replace-grammar branch from 7451c53 to 820dded Compare May 11, 2023 11:01
@mdesmet mdesmet requested a review from kasiafi May 11, 2023 11:04
@mdesmet mdesmet force-pushed the feature/create-or-replace-grammar branch 2 times, most recently from 60bb642 to 7900ed4 Compare May 12, 2023 10:00
kasiafi
kasiafi reviewed May 30, 2023
View reviewed changes
@mdesmet mdesmet force-pushed the feature/create-or-replace-grammar branch 2 times, most recently from f9cfe96 to cb96e14 Compare June 5, 2023 20:00
@mdesmet mdesmet requested a review from kasiafi June 6, 2023 08:08
@mdesmet
Copy link
Copy Markdown
Contributor Author

mdesmet commented Jun 6, 2023

@kasiafi: PTAL, I treated all comments.

@grantatspothero
Copy link
Copy Markdown
Contributor

grantatspothero commented Jun 7, 2023

Create or replace is a nice feature for external systems integrating with Trino (DBT/Airbyte/etc).

Any movement on the parser changes?

@mdesmet
Copy link
Copy Markdown
Contributor Author

mdesmet commented Jun 15, 2023

@martint : Can you have a look again?

martint
martint reviewed Jun 15, 2023
View reviewed changes
@Fokko
Copy link
Copy Markdown
Contributor

Fokko commented Jun 30, 2023

@mdesmet This looks very close, can we push this over the finish line?

@mdesmet mdesmet force-pushed the feature/create-or-replace-grammar branch from cb96e14 to a920ff4 Compare June 30, 2023 15:28
@mdesmet
Copy link
Copy Markdown
Contributor Author

mdesmet commented Jun 30, 2023

@martint : I took care of the comments. Can you PTAL?

@mdesmet mdesmet requested a review from martint July 4, 2023 19:20
martint
martint reviewed Jul 5, 2023
View reviewed changes
@mdesmet mdesmet force-pushed the feature/create-or-replace-grammar branch from a920ff4 to be29a60 Compare July 5, 2023 08:35
@mdesmet
Copy link
Copy Markdown
Contributor Author

mdesmet commented Jul 5, 2023

@martint : comments treated. PTAL

@mdesmet mdesmet requested a review from martint July 5, 2023 08:35
@martint martint merged commit 7e138ca into trinodb:master Jul 5, 2023
@github-actions github-actions bot added this to the 421 milestone Jul 5, 2023
@colebow colebow mentioned this pull request Jul 5, 2023
Merged
@mdesmet mdesmet mentioned this pull request Sep 30, 2023
Merged
@findinpath findinpath mentioned this pull request Apr 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ebyhr ebyhr ebyhr approved these changes

@findepi findepi findepi approved these changes

@kasiafi kasiafi kasiafi approved these changes

@electrum electrum Awaiting requested review from electrum

@martint martint Awaiting requested review from martint

Assignees

@mdesmet mdesmet

Labels

cla-signed

Milestone

421

Development

Successfully merging this pull request may close these issues.

7 participants

@mdesmet @findepi @grantatspothero @Fokko @martint @ebyhr @kasiafi