Validate correctness of supportsReportingWrittenBytes#17037
Merged
losipiuk merged 6 commits intotrinodb:masterfrom Apr 15, 2023
Merged
Conversation
findepi
added
test
no-release-notes
findepi
requested review from
losipiuk,
radek-kondziolka,
raunaqmorarka and
sopel39
findepi
force-pushed
the
findepi/validate-correctness-of-supportsreportingwrittenbytes-7f1bbc
branch
from
5f6e8b0 to
82468b3
Compare
losipiuk
approved these changes
Apr 14, 2023
raunaqmorarka
approved these changes
Apr 14, 2023
findepi
force-pushed
the
findepi/validate-correctness-of-supportsreportingwrittenbytes-7f1bbc
branch
from
82468b3 to
e0d7155
Compare
Member
Author
|
(just reordered commits, no other changes) |
Let `BaseConnectorTest.isReportingWrittenBytesSupported` synthesize valid table properties (with correct default values). A connector may depend on property value (either explicit or default).
In write statistics tests verify that connector not reporting stats indeed does not report them, i.e. that the `ConnectorMetadata.supportsReportingWrittenBytes` is correct.
findepi
force-pushed
the
findepi/validate-correctness-of-supportsreportingwrittenbytes-7f1bbc
branch
from
c4b5989 to
4f78cfa
Compare
findepi
deleted the
findepi/validate-correctness-of-supportsreportingwrittenbytes-7f1bbc
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In write statistics tests verify that connector not reporting stats
indeed does not report them, i.e. that the
ConnectorMetadata.supportsReportingWrittenBytesis correct.