Remove duplicate ChunkedSliceOutput class#17034
Merged
findepi merged 2 commits intotrinodb:masterfrom Apr 18, 2023
Merged
Conversation
findepi
added
the
no-release-notes
findepi
force-pushed
the
findepi/remove-duplicate-chunkedsliceoutput-class-573522
branch
from
7bb0987 to
d31d4ea
Compare
Member
There was a problem hiding this comment.
Why not delete the one in orc instead ?
Having it here makes it easier for other file formats to use this as well
Member
Author
There was a problem hiding this comment.
please see where trino-orc is used and where trino-hive-formats is used. do you still think we should do other way?
Member
There was a problem hiding this comment.
Okay, we shouldn't take dependency of trino-hive-formats in trino-orc as it gets included in iceberg and delta. But now I also think taking dependency of trino-orc in trino-hive-formats is confusing as it looks like trino-hive-formats is supposed to be code for hive file formats other than orc and parquet.
Maybe we move this class to trino-plugin-toolkit ?
We have two copies of `ChunkedSliceOutputs` and they are almost identical. The difference looks unintentional, eliminate.
findepi
force-pushed
the
findepi/remove-duplicate-chunkedsliceoutput-class-573522
branch
from
d31d4ea to
1a77f0a
Compare
Member
Author
|
(just rebased to resolve coflicts) |
findepi
force-pushed
the
findepi/remove-duplicate-chunkedsliceoutput-class-573522
branch
from
1a77f0a to
e511ac4
Compare
raunaqmorarka
approved these changes
Apr 17, 2023
losipiuk
approved these changes
Apr 17, 2023
findepi
deleted the
findepi/remove-duplicate-chunkedsliceoutput-class-573522
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.