Avoid array list shift in ChunkedSliceOutput#17031
Merged
findepi merged 2 commits intotrinodb:masterfrom Apr 17, 2023
Merged
Conversation
findepi
added
the
no-release-notes
findepi
force-pushed
the
findepi/avoid-array-list-shift-in-chunkedsliceoutput-29e2c3
branch
from
4a554c1 to
69288a4
Compare
losipiuk
approved these changes
Apr 14, 2023
Member
losipiuk
left a comment
losipiuk
left a comment
There was a problem hiding this comment.
LGTM. Is it covered by some tests?
Member
Author
I am convinced this is not dead code, but would defer to @dain for this. Unless you mean explicit unit test for this class, then I don't think so |
Member
Author
|
@losipiuk there indeed is coverage and i made some mistake will fix shortly |
Previously, the buffer allocation would remove first element of an `ArrayList`, causing a shift of all elements. This is rather ignorable: buffers get allocated bigger and bigger, so there aren't many buffer allocations. Still, it can be avoided, by keeping buffers on one list instead of two.
findepi
force-pushed
the
findepi/avoid-array-list-shift-in-chunkedsliceoutput-29e2c3
branch
from
69288a4 to
9661bd9
Compare
Member
Author
|
CI #17052 |
findepi
deleted the
findepi/avoid-array-list-shift-in-chunkedsliceoutput-29e2c3
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the buffer allocation would remove first element of an
ArrayList, causing a shift of all elements. This is rather ignorable: buffers get allocated bigger and bigger, so there aren't many buffer allocations. Still, it can be avoided, by keeping buffers on one list instead of two.