Skip to content

Fix TestHiveFileFormats flakiness due to Apache Parquet reader #17022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
findepi merged 2 commits into from
Apr 14, 2023
Merged

Fix TestHiveFileFormats flakiness due to Apache Parquet reader #17022

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9b7a56
Remove test group annotation
findepi Apr 13, 2023
d240959
Fix TestHiveFileFormats flakiness due to Apache Parquet reader
findepi Apr 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions lib/trino-orc/src/test/java/io/trino/orc/TestFullOrcReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@
*/
package io.trino.orc;

import org.testng.annotations.Test;

@Test(groups = "ci")
public class TestFullOrcReader
extends AbstractTestOrcReader
{
Expand Down
2 changes: 0 additions & 2 deletions plugin/trino-hive/src/test/java/io/trino/plugin/hive/AbstractTestHiveFileFormats.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@
import org.joda.time.DateTime;
import org.joda.time.DateTimeZone;
import org.joda.time.format.DateTimeFormat;
import org.testng.annotations.Test;

import java.io.File;
import java.io.IOException;
Expand Down Expand Up @@ -146,7 +145,6 @@
import static org.testng.Assert.assertFalse;
import static org.testng.Assert.assertTrue;

@Test(groups = "hive")
public abstract class AbstractTestHiveFileFormats
{
protected static final DateTimeZone HIVE_STORAGE_TIME_ZONE = DateTimeZone.forID("America/Bahia_Banderas");
Expand Down
4 changes: 4 additions & 0 deletions plugin/trino-hive/src/test/java/io/trino/plugin/hive/TestHiveFileFormats.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,10 @@
import static org.testng.Assert.assertNotNull;
import static org.testng.Assert.assertTrue;

// Failing on multiple threads because of org.apache.hadoop.hive.ql.io.parquet.write.ParquetRecordWriterWrapper
// uses a single record writer across all threads.
// For example org.apache.parquet.column.values.factory.DefaultValuesWriterFactory#DEFAULT_V1_WRITER_FACTORY is shared mutable state.
@Test(singleThreaded = true)
public class TestHiveFileFormats
extends AbstractTestHiveFileFormats
{
Expand Down
1 change: 1 addition & 0 deletions plugin/trino-hive/src/test/java/io/trino/plugin/hive/parquet/TestFullParquetReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

// Failing on multiple threads because of org.apache.hadoop.hive.ql.io.parquet.write.ParquetRecordWriterWrapper
// uses a single record writer across all threads.
// For example org.apache.parquet.column.values.factory.DefaultValuesWriterFactory#DEFAULT_V1_WRITER_FACTORY is shared mutable state.
@Test(singleThreaded = true)
public class TestFullParquetReader
extends AbstractTestParquetReader
Expand Down
1 change: 1 addition & 0 deletions plugin/trino-hive/src/test/java/io/trino/plugin/hive/parquet/TestOptimizedParquetReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

// Failing on multiple threads because of org.apache.hadoop.hive.ql.io.parquet.write.ParquetRecordWriterWrapper
// uses a single record writer across all threads.
// For example org.apache.parquet.column.values.factory.DefaultValuesWriterFactory#DEFAULT_V1_WRITER_FACTORY is shared mutable state.
@Test(singleThreaded = true)
public class TestOptimizedParquetReader
extends AbstractTestParquetReader
Expand Down
1 change: 1 addition & 0 deletions plugin/trino-hive/src/test/java/io/trino/plugin/hive/parquet/TestParquetReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

// Failing on multiple threads because of org.apache.hadoop.hive.ql.io.parquet.write.ParquetRecordWriterWrapper
// uses a single record writer across all threads.
// For example org.apache.parquet.column.values.factory.DefaultValuesWriterFactory#DEFAULT_V1_WRITER_FACTORY is shared mutable state.
@Test(singleThreaded = true)
public class TestParquetReader
extends AbstractTestParquetReader
Expand Down