Add support for CUBE and ROLLUP with composite sets#17007
Merged
martint merged 2 commits intotrinodb:masterfrom Apr 17, 2023
Merged
Add support for CUBE and ROLLUP with composite sets#17007martint merged 2 commits intotrinodb:masterfrom
martint merged 2 commits intotrinodb:masterfrom
Conversation
kasiafi
reviewed
Apr 14, 2023
core/trino-parser/src/main/java/io/trino/sql/tree/GroupingSets.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/planner/QueryPlanner.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/planner/QueryPlanner.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/analyzer/StatementAnalyzer.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/analyzer/StatementAnalyzer.java
Outdated
Show resolved
Hide resolved
Previously, CUBE and ROLLUP only allowed simple groups
composed of single column references. This change makes
it possible to specify composite groups such as:
GROUP BY CUBE ((a,b), c, (d, e, f))
GroupingElement, Cube and Rollup contain the same information and look very similar. Replace them with a single class and and enum to indicate the type of grouping sets clause they represent.
kasiafi
approved these changes
Apr 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, CUBE and ROLLUP only allowed simple groups composed of single column references. This change makes it possible to specify composite groups such as:
Fixes #16981
Release notes
(x) Release notes are required, with the following suggested text: