Test SHOW TABLES after relation creation#16993
Merged
findepi merged 3 commits intotrinodb:masterfrom Apr 14, 2023
Merged
Conversation
Move them from `QueryAssert` to `MaterializedResult`.
ebyhr
approved these changes
Apr 12, 2023
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java
Outdated
Show resolved
Hide resolved
krvikash
approved these changes
Apr 13, 2023
findepi
force-pushed
the
findepi/test-show-tables-after-relation-creation-e47c9c
branch
from
cdab9de to
7a81cd5
Compare
findepi
force-pushed
the
findepi/test-show-tables-after-relation-creation-e47c9c
branch
from
7a81cd5 to
0d764f5
Compare
hashhar
reviewed
Apr 14, 2023
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java
Outdated
Show resolved
Hide resolved
hashhar
reviewed
Apr 14, 2023
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java
Outdated
Show resolved
Hide resolved
findepi
force-pushed
the
findepi/test-show-tables-after-relation-creation-e47c9c
branch
from
e86e9cb to
8c86936
Compare
Move `AbstractTestQueries.testShowTables` to `AbstractTestEngineOnlyQueries`. Add `BaseConnectorTest.testShowTables` testing `SHOW TABLES` with a connector after a table or view is created in the connector.
findepi
force-pushed
the
findepi/test-show-tables-after-relation-creation-e47c9c
branch
from
8c86936 to
55bd4d6
Compare
findepi
deleted the
findepi/test-show-tables-after-relation-creation-e47c9c
branch
colebow
added
the
no-release-notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move
AbstractTestQueries.testShowTablestoAbstractTestEngineOnlyQueries.Add
BaseConnectorTest.testShowTablestestingSHOW TABLESwith aconnector after a table or view is created in the connector.