Ensure test threads termination even when test overridden#16991
Conversation
findepi
added
test
no-release-notes
There was a problem hiding this comment.
The commit message is Ensure test threads termination even when test overridden - feels like a general change; but it is for specific test only.
There was a problem hiding this comment.
wait - did you miss throw failure here?
There was a problem hiding this comment.
wait - did you miss
throw failurehere?
good catch!
The commit message is
Ensure test threads termination even when test overridden- feels like a general change; but it is for specific test only.
yes, but i couldn't put testReadMetadataWithRelationsConcurrentModifications in the title line, could i?
There was a problem hiding this comment.
Actually the following text was misleading to me. It was stating testReadMetadataWithRelationsConcurrentModifications as an "example" - which I interpreted as the change is more generic, and you are explaining why it is helpful using this specifi testcase.
There was a problem hiding this comment.
now that i have read the commit message, i see your point. reworded
findepi
force-pushed
the
findepi/fix-sqlserver-testReadMetadataWithRelationsConcurrentModifications
branch
from
b8680ee to
56af54b
Compare
github-actions
bot
added
hive
…rrentModifications `BaseSqlServerConnectorTest` overrides `testReadMetadataWithRelationsConcurrentModifications`. Before the change, the test invocation could leave background task running, eventually leading to failure during `AbstractTestQueryFramework.close` (in `checkQueryInfosFinal()`).
findepi
force-pushed
the
findepi/fix-sqlserver-testReadMetadataWithRelationsConcurrentModifications
branch
from
56af54b to
f0ba4e4
Compare
findepi
deleted the
findepi/fix-sqlserver-testReadMetadataWithRelationsConcurrentModifications
branch
3 participants
For example
BaseSqlServerConnectorTestoverridestestReadMetadataWithRelationsConcurrentModifications. Before thechange, the test invocation could leave background task running,
eventually leading to failure during
AbstractTestQueryFramework.close(in
checkQueryInfosFinal()).Fixes #15430