Skip to content

Update docker-images to version 79#16921

Closed
ebyhr wants to merge 1 commit intotrinodb:masterfrom
ebyhr:ebi/docker-79
Closed

Update docker-images to version 79#16921
ebyhr wants to merge 1 commit intotrinodb:masterfrom
ebyhr:ebi/docker-79

Conversation

@ebyhr
Copy link
Copy Markdown
Member

@ebyhr ebyhr commented Apr 7, 2023

Description

Update docker-images to version 79

Release notes

(x) This is not user-visible or docs only and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Apr 7, 2023
@ebyhr ebyhr added the no-release-notes This pull request does not require release notes entry label Apr 7, 2023
@findinpath
Copy link
Copy Markdown
Contributor

findinpath commented Apr 7, 2023

Tests are red

2023-04-07 11:32:20 INFO: FAILURE     /    io.trino.tests.product.iceberg.TestIcebergPartitionEvolution.testDroppedPartitionField [true] (Groups: profile_specific_tests, iceberg) took 3.0 seconds
tests               | 2023-04-07 11:32:20 SEVERE: Failure cause:
tests               | java.lang.AssertionError: Could not find rows:
tests               | [a, null, null, 0.16666666667, null, null, null]
tests               | [b, null, null, 0.16666666667, null, null, null]
tests               | [c, null, null, 0.00000000000, null, null, null]
tests               | 
tests               | actual rows:
tests               | [a, null, 3.00000000000, 0.16666666667, null, null, null]
tests               | [b, null, 3.00000000000, 0.16666666667, null, null, null]
tests               | [c, null, 4.00000000000, 0.00000000000, null, null, null]
tests               | [null, null, null, null, 6.00000000000, null, null]

It is probably caused by trinodb/docker-images#164 and to the issues found in #16557

@ebyhr
Copy link
Copy Markdown
Member Author

ebyhr commented Apr 7, 2023

The error message is different from #16557 and the new row is the expected result in my understanding.

@findinpath
Copy link
Copy Markdown
Contributor

Can it be that what we've found in #16921 (comment) is a side-effect of bf04a72 ?

I wonder why it didn't pop up before ...

cc @findepi

@ebyhr
Copy link
Copy Markdown
Member Author

ebyhr commented Apr 7, 2023

Can it be that what we've found in #16921 (comment) is a side-effect of bf04a72 ?

I don't think so. I suppose ALTER TABLE ... DROP PARTITION FIELD on old Iceberg Spark didn't handle puffin files correctly (or did something wrong) and then SHOW STATS returned incorrect results.

@ebyhr
Copy link
Copy Markdown
Member Author

ebyhr commented Apr 7, 2023

The following failure looks an actual issue.

2023-04-07T14:55:57.2405351Z tests               | 2023-04-07 20:40:57 INFO: FAILURE     /    io.trino.tests.product.iceberg.TestIcebergSparkCompatibility.testPartialStats (Groups: iceberg_jdbc, profile_specific_tests, iceberg, iceberg_rest) took 1.3 seconds
2023-04-07T14:55:57.2406262Z tests               | 2023-04-07 20:40:57 SEVERE: Failure cause:
2023-04-07T14:55:57.2407066Z tests               | io.trino.tempto.query.QueryExecutionException: java.sql.SQLException: org.apache.hive.service.cli.HiveSQLException: Error running query: org.apache.iceberg.exceptions.CommitStateUnknownException: Service failed: 500: {
2023-04-07T14:55:57.2407910Z tests               | "cause1":"java.lang.IllegalArgumentException: Cannot parse missing map: updated",
2023-04-07T14:55:57.2408961Z tests               | "servlet":"org.apache.iceberg.rest.RESTCatalogServlet-6385cb26",
2023-04-07T14:55:57.2410434Z tests               | "cause0":"com.fasterxml.jackson.databind.JsonMappingException: Cannot parse missing map: updated (through reference chain: org.apache.iceberg.rest.requests.UpdateTableRequest["updates"]->java.util.ArrayList[0])",
2023-04-07T14:55:57.2411843Z tests               | "message":"com.fasterxml.jackson.databind.JsonMappingException: Cannot parse missing map: updated (through reference chain: org.apache.iceberg.rest.requests.UpdateTableRequest["updates"]->java.util.ArrayList[0])",
2023-04-07T14:55:57.2412603Z tests               | "url":"/v1/namespaces/default/tables/test_partial_stats_sznstttwsl",
2023-04-07T14:55:57.2412942Z tests               | "status":"500"

@findinpath
Copy link
Copy Markdown
Contributor

@ebyhr pls update

to

    private static final String REST_SERVER_IMAGE = "tabulario/iceberg-rest:0.3.0";

which will solve the failing test TestIcebergSparkCompatibility.testPartialStats

@ebyhr
Copy link
Copy Markdown
Member Author

ebyhr commented Apr 11, 2023

@findinpath Thanks!

Let me continue in #16957 to run with secrets.

@ebyhr ebyhr closed this Apr 11, 2023
@ebyhr ebyhr deleted the ebi/docker-79 branch April 11, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed no-release-notes This pull request does not require release notes entry

Development

Successfully merging this pull request may close these issues.

2 participants