Add escape character in like predicate for SHOW CATALOGS#1691
Merged
martint merged 1 commit intotrinodb:masterfrom Oct 30, 2019
Merged
Add escape character in like predicate for SHOW CATALOGS#1691martint merged 1 commit intotrinodb:masterfrom
martint merged 1 commit intotrinodb:masterfrom
Conversation
martint
requested changes
Oct 9, 2019
Member
There was a problem hiding this comment.
This should go in TestParserErrorHandling. Generally, we try to avoid engine-specific tests in AbstractTestQueries, since these run for every connector and can extend test run time considerably.
Member
There was a problem hiding this comment.
These two should go in TestAnalyzer
Member
There was a problem hiding this comment.
Move this one to an engine-specific test (similar to the ones in io.prestosql.sql.query.TestXXX). It'd be nice to also have a positive test. There's a catalog named testing_catalog in LocalQueryRunner that you can use for that purpose.
Praveen2112
force-pushed
the
show_catalogs_escape
branch
from
b197847 to
ca3b19a
Compare
Member
Author
|
@martint Thanks for your insights. Have applied the comments |
martint
approved these changes
Oct 16, 2019
Praveen2112
force-pushed
the
show_catalogs_escape
branch
2 times, most recently
from
e68f9d0 to
325f8dd
Compare
Praveen2112
force-pushed
the
show_catalogs_escape
branch
4 times, most recently
from
3c91259 to
043f626
Compare
Praveen2112
force-pushed
the
show_catalogs_escape
branch
from
043f626 to
5abd1a1
Compare
amitkdutta
pushed a commit
to amitkdutta/presto
that referenced
this pull request
May 15, 2022
Cherry-pick of trinodb/trino#1691 Co-authored-by: Praveen Krishna <praveenkrishna@tutanota.com>
tdcmeehan
pushed a commit
to prestodb/presto
that referenced
this pull request
May 17, 2022
Cherry-pick of trinodb/trino#1691 Co-authored-by: Praveen Krishna <praveenkrishna@tutanota.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.