Skip to content

Bump Iceberg to 1.2.1#16909

Closed
nastra wants to merge 3 commits intotrinodb:masterfrom
nastra:iceberg-1.2.1-rc
Closed

Bump Iceberg to 1.2.1#16909
nastra wants to merge 3 commits intotrinodb:masterfrom
nastra:iceberg-1.2.1-rc

Conversation

@nastra
Copy link
Copy Markdown
Contributor

@nastra nastra commented Apr 6, 2023

This is including the commits from #16557 and switches to using the RC for 1.2.1.
The purpose of the PR is to test whether apache/iceberg#7235 is fixed when running TestIcebergSparkCompatibility with the REST catalog.

I'll close this PR once we verified the 1.2.1 RC. We can then include the official 1.2.1 release as part of #16557.

/cc @electrum

@cla-bot cla-bot bot added the cla-signed label Apr 6, 2023
@github-actions github-actions bot added the iceberg Iceberg connector label Apr 6, 2023
@nastra nastra force-pushed the iceberg-1.2.1-rc branch from 2f51cdc to aa0072e Compare April 6, 2023 16:26
@nastra
Copy link
Copy Markdown
Contributor Author

nastra commented Apr 6, 2023

@electrum the issue with reading the snapshot-id as an int should be fixed now and tests are passing. Could somebody from your team double-check the other test failures (BaseIcebergConnectorTest#testExpireSnapshots())?

@nastra nastra changed the title Bump Iceberg to 1.2.1 RC Bump Iceberg to 1.2.1 Apr 12, 2023
@nastra nastra force-pushed the iceberg-1.2.1-rc branch from 983da16 to 2a649e9 Compare April 12, 2023 05:40
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes in this test and the following one are related to Iceberg 1.2.0 + #15441

Copy link
Copy Markdown
Contributor Author

@nastra nastra Apr 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is related to 1.2.0 and not to 1.2.1. There's one more event now because the stats file gets deleted as well

@nastra nastra force-pushed the iceberg-1.2.1-rc branch from 2a649e9 to 14b6577 Compare April 12, 2023 06:14
Copy link
Copy Markdown
Contributor Author

@nastra nastra Apr 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

old stats files are getting cleaned up with 1.2.0 now due to apache/iceberg#6090

@nastra nastra force-pushed the iceberg-1.2.1-rc branch from 14b6577 to 4b38cc8 Compare April 12, 2023 07:25
@nastra
Copy link
Copy Markdown
Contributor Author

nastra commented Apr 19, 2023

superseded by #16557

@nastra nastra closed this Apr 19, 2023
@nastra nastra deleted the iceberg-1.2.1-rc branch April 19, 2023 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed iceberg Iceberg connector

Development

Successfully merging this pull request may close these issues.

3 participants