Notifies systemSecurityMetadata on column add, rename, and drop events if using system security manager#16833
Conversation
core/trino-main/src/main/java/io/trino/metadata/DisabledSystemSecurityMetadata.java
Outdated
Show resolved
Hide resolved
testing/trino-tests/src/test/java/io/trino/security/TestingSystemSecurityMetadata.java
Outdated
Show resolved
Hide resolved
3fa59f1 to
99e3e9f
Compare
|
@ebyhr I have made the requested changes. A couple of the tests are failing. I'd like to re-run the failing tests to see if they're consistently failing or if they're flaky tests, but I don't have permission to do so. Would it be possible to get those tests kicked off again? Thanks for the quick review! |
|
You can create an empty commit ( |
|
Thanks @ebyhr! I have done that, and the tests have passed. Would it be possible to check again when you get a free moment? |
djsagain
left a comment
There was a problem hiding this comment.
This looked great! I left one hyper-nit.
There was a problem hiding this comment.
Hyper-nit - - since it's only used only in the if stm, I would have been tempted to move the catalogMetadata value into the if stm here and in the other two methods.
There was a problem hiding this comment.
I thought about that too. I'd rather keep it as-is though, personally; it matches the style of other methods that notify system security metadata.
092e4e3 to
e85e94b
Compare
e85e94b to
8020fda
Compare
Description
This PR adds support for notifying SystemSecurityMetadata for column add/drop/rename events.
This was previously unsuccessfully implemented in this PR, but this PR bypasses the need to call
getTableMetadata(session, tableHandle)by passing thetableNamedirectly from the[Add|Rename|Drop]ColumnTaskto get it to work with various connectors that don't allow it.There will likely need to be coordination with this outstanding PR as the interface changes in this one will break the new tests in the linked one. Happy to wait to merge this change until #16759 has been merged, but looking for some feedback.
Additional context and related issues
Release notes
(x) This is not user-visible or docs only and no release notes are required.