Simplify TestingConnectorBehavior declarations #16825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashhar
reviewed
Mar 31, 2023
Member
hashhar
left a comment
hashhar
left a comment
There was a problem hiding this comment.
I agree. Makes sense. Will revisit once CI results are available.
findepi
force-pushed
the
findepi/simplify-testingconnectorbehavior-declarations-279279
branch
from
d27c8d9 to
1898934
Compare
github-actions
bot
added
delta-lake
findepi
force-pushed
the
findepi/simplify-testingconnectorbehavior-declarations-279279
branch
3 times, most recently
from
5a6f2ca to
8569550
Compare
findepi
commented
Apr 14, 2023
| @@ -15,8 +15,8 @@ | |||
|
|
|||
| import static io.trino.plugin.pinot.TestingPinotCluster.PINOT_LATEST_IMAGE_NAME; | |||
|
|
|||
| public class TestPinotWithoutAuthenticationIntegrationLatestVersionNoGrpcConnectorSmokeTest | |||
Member
Author
There was a problem hiding this comment.
After i made this class names a little shorter i realized we don't have non-Smoke BCT coverage for Pinot yet.
@elonazoulay is there an issue for this already?
Member
There was a problem hiding this comment.
There is no issue but I can create a BCT for pinot.
Member
Author
findepi
force-pushed
the
findepi/simplify-testingconnectorbehavior-declarations-279279
branch
from
8569550 to
36cc6d0
Compare
Member
Author
|
CI #17033 |
findepi
requested review from
alexjo2144,
ebyhr,
hashhar,
kokosing,
losipiuk and
raunaqmorarka
ebyhr
approved these changes
Apr 18, 2023
Member
ebyhr
left a comment
ebyhr
left a comment
There was a problem hiding this comment.
Left minor comments. Please ignore if those codes are intentional.
| return true; | ||
|
|
||
| case SUPPORTS_CREATE_MATERIALIZED_VIEW: | ||
| return true; |
Member
There was a problem hiding this comment.
Can we remove SUPPORTS_CREATE_VIEW & SUPPORTS_CREATE_MATERIALIZED_VIEW?
Comment on lines
27
to
28
| case SUPPORTS_DELETE: | ||
| return true; |
findepi
force-pushed
the
findepi/simplify-testingconnectorbehavior-declarations-279279
branch
from
c32e02f to
8ff3371
Compare
hashhar
approved these changes
Apr 19, 2023
findepi
force-pushed
the
findepi/simplify-testingconnectorbehavior-declarations-279279
branch
from
b5c8cd3 to
900f21e
Compare
The "Integration" looked like a remnant of the old naming convention before BCT and BCST were introduced. The "LatestVersion" is usually written as just "latest". Remove other unnecessary words and make the class names readable.
Use `true` or a related behavior as the default rather than `false`. Few cases being off by default remain, but generally true as the default is much easier to reason about. False defaults were usually a result of incremental additions, where it's easier to add a behavior that is not widely adopted, but are harder to think about in a long run.
findepi
force-pushed
the
findepi/simplify-testingconnectorbehavior-declarations-279279
branch
from
900f21e to
c93bd71
Compare
Member
Author
|
CI #13995 |
findepi
deleted the
findepi/simplify-testingconnectorbehavior-declarations-279279
branch
colebow
added
the
no-release-notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
trueor a related behavior as the default rather thanfalse. Few cases being off by default remain, but generally true as the default is much easier to reason about. False defaults were usually a result of incremental additions, where it's easier to add a behavior that is not widely adopted, but are harder to think about in a long run.cc @hashhar @ebyhr