Add missing config properties to Hive docs#16808
Conversation
findinpath
left a comment
findinpath
left a comment
There was a problem hiding this comment.
I verified the default values for all the newly added properties and everything seems to correspond to the Trino codebase.
There are small formatting issues, but besides that I think the PR is good to go.
Some of these properties could have a story of their own to be expanded to give more context to the users, but having their existence documented is a really good addition.
colebow
force-pushed
the
colebow/add-missing-hive-properties
branch
from
4dbfe74 to
e659161
Compare
You're being generous with the world "small," I've got no idea what happened there. 😆 |
There was a problem hiding this comment.
A convention we chose for a lot of table is to NOT have a default column because a lot of properties dont have a default defined.. so I suggest to undo these unrelated changes.
There was a problem hiding this comment.
I think it makes sense, because this is adding a lot of rows to the table that do have default values.
colebow
force-pushed
the
colebow/add-missing-hive-properties
branch
from
e659161 to
4a246b0
Compare
|
@ebyhr CPTAL over the addition of the docs for these Hive settings? |
There was a problem hiding this comment.
Co-authored by ...
The right syntax is Co-Authored-By (2nd - is missing).
ebyhr
force-pushed
the
colebow/add-missing-hive-properties
branch
from
4a246b0 to
9e3faa2
Compare
Co-Authored-By: Marius Grama <findinpath@gmail.com>
ebyhr
force-pushed
the
colebow/add-missing-hive-properties
branch
from
9e3faa2 to
62ff474
Compare
5 participants
Description
Lifting some of the config docs improvements from #10831. Attribution to @findinpath is in the commit message.
Release notes
(x) This is not user-visible or docs only and no release notes are required.