Skip to content

Fix handling of various table types in BigQuery connector #16737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hashhar merged 3 commits into from
Mar 29, 2023
Merged

Fix handling of various table types in BigQuery connector #16737

hashhar merged 3 commits into from
Mar 29, 2023

Conversation

@hashhar
Copy link
Member

@hashhar hashhar commented Mar 27, 2023

Release notes

( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text:

# BigQuery
* Fix failure of aggregation queries when executed against a materialized view, external table or snapshot table in BigQuery. ({issue}`15546`)

Fixes #15546

@hashhar hashhar added the bigquery BigQuery connector label Mar 27, 2023
@hashhar hashhar requested a review from ebyhr March 27, 2023 08:01
@cla-bot cla-bot bot added the cla-signed label Mar 27, 2023
ebyhr
ebyhr approved these changes Mar 27, 2023
View reviewed changes
@ebyhr
Copy link
Member

ebyhr commented Mar 27, 2023

hashhar added the bigquery BigQuery connector label 1 hour ago

FYI: By the way, labeler job adds the label automatically when the PR changes under plugin/trino-bigquery 🙂

@hashhar hashhar force-pushed the hashhar/bq-empty-projection branch 2 times, most recently from 18d094a to 9c0ed95 Compare March 27, 2023 11:42
@hashhar
Copy link
Member Author

hashhar commented Mar 27, 2023

AC @ebyhr

@hashhar hashhar force-pushed the hashhar/bq-empty-projection branch 3 times, most recently from 1ecdd2e to 5ad8883 Compare March 28, 2023 07:43
@hashhar
Copy link
Member Author

hashhar commented Mar 28, 2023 •
edited
Loading

Seems we cannot use both DataProvider and Parameters at the same time. Had to add the parameter to the @BeforeClass instead. PTAL again @ebyhr.

Here's the diff https://github.com/trinodb/trino/compare/1ecdd2e74ad0688dcd2e52ef863baa48151b82dc..5ad8883debbfa21936f28a292bf9c3cb3b1460db

ebyhr
ebyhr approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for check-commit failure.

hashhar added 2 commits March 29, 2023 13:08
@hashhar
Consistently handle table types across BigQuery connector
cbbd184 
This also fixes a bug where createEmptyProjection failed for non-TABLE
and non-VIEW even though those could be supported.
@hashhar
Combine some redundant tests in BigQuery
84c8a55
@hashhar hashhar force-pushed the hashhar/bq-empty-projection branch from 5ad8883 to 84c8a55 Compare March 29, 2023 07:38
@hashhar hashhar merged commit 8cd3ba6 into master Mar 29, 2023
@hashhar hashhar deleted the hashhar/bq-empty-projection branch March 29, 2023 13:15
@github-actions github-actions bot added this to the 411 milestone Mar 29, 2023
@colebow colebow mentioned this pull request Mar 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ebyhr ebyhr ebyhr approved these changes

Assignees

No one assigned

Labels

bigquery BigQuery connector cla-signed

Milestone

411

Development

Successfully merging this pull request may close these issues.

Aggregation on non-table or non-view fail in BigQuery

3 participants

@hashhar @ebyhr