-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Verify authorization access for SET AUTHORIZATION statements #16691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kokosing
merged 3 commits into
trinodb:master
from
kokosing:origin/master/177_alter_view_authorization
Jun 7, 2023
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| { | ||
| "authorization": [ | ||
| { | ||
| "original_role": "admin", | ||
| "new_user": "bob", | ||
| "allow": false | ||
| }, | ||
| { | ||
| "original_role": "admin", | ||
| "new_user": ".*", | ||
| "new_role": ".*" | ||
| } | ||
| ], | ||
| "schemas": [ | ||
| { | ||
| "role": "admin", | ||
| "owner": true | ||
| } | ||
| ], | ||
| "tables": [ | ||
| { | ||
| "role": "admin", | ||
| "privileges": ["OWNERSHIP"] | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
85 changes: 85 additions & 0 deletions
85
lib/trino-plugin-toolkit/src/main/java/io/trino/plugin/base/security/AuthorizationRule.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| /* | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package io.trino.plugin.base.security; | ||
|
|
||
| import com.fasterxml.jackson.annotation.JsonAlias; | ||
| import com.fasterxml.jackson.annotation.JsonCreator; | ||
| import com.fasterxml.jackson.annotation.JsonProperty; | ||
| import io.trino.spi.security.TrinoPrincipal; | ||
|
|
||
| import java.util.Optional; | ||
| import java.util.Set; | ||
| import java.util.regex.Pattern; | ||
|
|
||
| import static com.google.common.base.MoreObjects.firstNonNull; | ||
| import static com.google.common.base.Preconditions.checkArgument; | ||
| import static java.lang.Boolean.TRUE; | ||
| import static java.util.Objects.requireNonNull; | ||
|
|
||
| public class AuthorizationRule | ||
| { | ||
| private final Optional<Pattern> originalUserPattern; | ||
| private final Optional<Pattern> originalGroupPattern; | ||
| private final Optional<Pattern> originalRolePattern; | ||
| private final Optional<Pattern> newUserPattern; | ||
| private final Optional<Pattern> newRolePattern; | ||
| private final boolean allow; | ||
|
|
||
| @JsonCreator | ||
| public AuthorizationRule( | ||
| @JsonProperty("original_user") @JsonAlias("originalUser") Optional<Pattern> originalUserPattern, | ||
| @JsonProperty("original_group") @JsonAlias("originalGroup") Optional<Pattern> originalGroupPattern, | ||
| @JsonProperty("original_role") @JsonAlias("originalRole") Optional<Pattern> originalRolePattern, | ||
| @JsonProperty("new_user") @JsonAlias("newUser") Optional<Pattern> newUserPattern, | ||
| @JsonProperty("new_role") @JsonAlias("newRole") Optional<Pattern> newRolePattern, | ||
| @JsonProperty("allow") Boolean allow) | ||
| { | ||
| checkArgument(newUserPattern.isPresent() || newRolePattern.isPresent(), "At least one of new_use or new_role is required, none were provided"); | ||
| this.originalUserPattern = requireNonNull(originalUserPattern, "originalUserPattern is null"); | ||
| this.originalGroupPattern = requireNonNull(originalGroupPattern, "originalGroupPattern is null"); | ||
| this.originalRolePattern = requireNonNull(originalRolePattern, "originalRolePattern is null"); | ||
| this.newUserPattern = requireNonNull(newUserPattern, "newUserPattern is null"); | ||
| this.newRolePattern = requireNonNull(newRolePattern, "newRolePattern is null"); | ||
| this.allow = firstNonNull(allow, TRUE); | ||
| } | ||
|
|
||
| public Optional<Boolean> match(String user, Set<String> groups, Set<String> roles, TrinoPrincipal newPrincipal) | ||
| { | ||
| if (originalUserPattern.map(regex -> regex.matcher(user).matches()).orElse(true) && | ||
| (originalGroupPattern.isEmpty() || groups.stream().anyMatch(group -> originalGroupPattern.get().matcher(group).matches())) && | ||
| (originalRolePattern.isEmpty() || roles.stream().anyMatch(role -> originalRolePattern.get().matcher(role).matches())) && | ||
| matches(newPrincipal)) { | ||
| return Optional.of(allow); | ||
| } | ||
| return Optional.empty(); | ||
| } | ||
|
|
||
| private boolean matches(TrinoPrincipal newPrincipal) | ||
| { | ||
| return switch (newPrincipal.getType()) { | ||
| case USER -> newUserPattern.map(regex -> regex.matcher(newPrincipal.getName()).matches()).orElse(false); | ||
| case ROLE -> newRolePattern.map(regex -> regex.matcher(newPrincipal.getName()).matches()).orElse(false); | ||
| }; | ||
| } | ||
|
|
||
| public Optional<Pattern> getOriginalRolePattern() | ||
| { | ||
| return originalRolePattern; | ||
| } | ||
|
|
||
| public Optional<Pattern> getNewRolePattern() | ||
| { | ||
| return newRolePattern; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.