Remove kill-switch to disable automatic fetch-size selection#16670
Merged
findepi merged 1 commit intotrinodb:masterfrom May 5, 2023
Merged
Conversation
|
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
findepi
force-pushed
the
findepi/remove-disable-automatic-fetch-size-kill-switch
branch
from
0b38b39 to
e091d15
Compare
findepi
added
the
no-release-notes
The configuration toggles `xxx.disable-automatic-fetch-size` were introduced only temporarily, as a kill-switch.
findepi
force-pushed
the
findepi/remove-disable-automatic-fetch-size-kill-switch
branch
from
e091d15 to
91b4bf0
Compare
wendigo
approved these changes
May 5, 2023
mosabua
approved these changes
May 5, 2023
Member
mosabua
left a comment
mosabua
left a comment
There was a problem hiding this comment.
Nice .. lets ship this now. I confirm that this was never documented so there is no need to remove anything from the docs ;-)
findepi
deleted the
findepi/remove-disable-automatic-fetch-size-kill-switch
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The configuration toggles
xxx.disable-automatic-fetch-sizewereintroduced only temporarily, as a kill-switch.
To be merged after some time since #16644 is merged and released (in 411).