Skip to content

Add link to duration prop type in JDBC config fragment #16638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ebyhr merged 1 commit into from
Mar 21, 2023
Merged

Add link to duration prop type in JDBC config fragment #16638

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions docs/src/main/sphinx/connector/jdbc-common-configurations.fragment
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,21 +15,21 @@ connector:
- Support case insensitive schema and table names.
- ``false``
* - ``case-insensitive-name-matching.cache-ttl``
-
- This value should be a :ref:`prop-type-duration`.
Copy link
Member

@mosabua mosabua Mar 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "Value must use duration formatting" ?

- ``1m``
* - ``case-insensitive-name-matching.config-file``
- Path to a name mapping configuration file in JSON format that allows
Trino to disambiguate between schemas and tables with similar names in
different cases.
- ``null``
* - ``case-insensitive-name-matching.refresh-period``
* - ``case-insensitive-name-matching.config-file.refresh-period``
- Frequency with which Trino checks the name matching configuration file
for changes.
- ``0`` (refresh disabled)
for changes. This value should be a :ref:`prop-type-duration`.
- (refresh disabled)
* - ``metadata.cache-ttl``
- Duration for which metadata, including table and column statistics, is
cached.
- ``0`` (caching disabled)
- :ref:`The duration <prop-type-duration>` for which metadata, including
table and column statistics, is cached.
- ``0s`` (caching disabled)
* - ``metadata.cache-missing``
- Cache the fact that metadata, including table and column statistics, is
not available
Expand All @@ -46,8 +46,8 @@ connector:
- Push down dynamic filters into JDBC queries
- ``true``
* - ``dynamic-filtering.wait-timeout``
- Maximum duration for which Trino will wait for dynamic filters to be
collected from the build side of joins before starting a JDBC query.
Using a large timeout can potentially result in more detailed dynamic filters.
However, it can also increase latency for some queries.
- Maximum :ref:`prop-type-duration` for which Trino will wait for dynamic
filters to be collected from the build side of joins before starting a
JDBC query. Using a large timeout can potentially result in more detailed
dynamic filters. However, it can also increase latency for some queries.
- ``20s``