Skip to content

Fix BaseFailureRecoveryTest temp table checking message pattern #16636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
findepi merged 1 commit into from
Mar 20, 2023
Merged

Fix BaseFailureRecoveryTest temp table checking message pattern #16636

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion testing/trino-testing/src/main/java/io/trino/testing/BaseFailureRecoveryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,7 @@ protected void checkTemporaryTables(Set<String> queryIds)
String temporaryTableName = (String) temporaryTableRow.getField(0);
try {
assertThatThrownBy(() -> getQueryRunner().execute("SELECT 1 FROM %s WHERE 1 = 0".formatted(temporaryTableName)))
.hasMessageContaining("%s does not exist", temporaryTableName);
.hasMessageContaining("Table '%s' does not exist", temporaryTableName);
Copy link
Copy Markdown
Member

@hashhar hashhar Apr 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@findepi Does temporaryTableName actually contain fully-qualified name? The error messages say Table 'catalog.schema.table_name' does not exist while temporaryTableName comes from SHOW TABLES LIKE which doesn't return fully-qualified names.

(asking before I submit a PR, I saw this happen locally but for a different connector I was trying to add FTE to)

Copy link
Copy Markdown
Member Author

@findepi findepi Apr 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hashhar thanks it seems you're right.

Copy link
Copy Markdown
Member Author

@findepi findepi Apr 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

being fixed by @ppalucha in #16977

}
catch (AssertionError e) {
remainingTemporaryTables.computeIfAbsent(queryId, ignored -> new HashSet<>()).add(temporaryTableName);
Expand Down