Skip to content

Improve LongSumAggregation and DoubleSumAggregation serde #16624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sopel39 merged 1 commit into from
Mar 19, 2023
Merged

Improve LongSumAggregation and DoubleSumAggregation serde #16624

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions core/trino-main/src/main/java/io/trino/operator/aggregation/LongDoubleState.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
*/
package io.trino.operator.aggregation;

import io.trino.operator.aggregation.state.InitialBooleanValue;
import io.trino.spi.function.AccumulatorState;

public interface LongDoubleState
Expand All @@ -23,17 +22,7 @@ public interface LongDoubleState

void setFirst(long first);

@InitialBooleanValue(true)
boolean isFirstNull();

void setFirstNull(boolean firstNull);

double getSecond();

void setSecond(double second);

@InitialBooleanValue(true)
boolean isSecondNull();

void setSecondNull(boolean secondNull);
}
11 changes: 0 additions & 11 deletions core/trino-main/src/main/java/io/trino/operator/aggregation/LongLongState.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
*/
package io.trino.operator.aggregation;

import io.trino.operator.aggregation.state.InitialBooleanValue;
import io.trino.spi.function.AccumulatorState;

public interface LongLongState
Expand All @@ -23,17 +22,7 @@ public interface LongLongState

void setFirst(long first);

@InitialBooleanValue(true)
boolean isFirstNull();

void setFirstNull(boolean firstNull);

long getSecond();

void setSecond(long second);

@InitialBooleanValue(true)
boolean isSecondNull();

void setSecondNull(boolean secondNull);
}
2 changes: 1 addition & 1 deletion testing/trino-tests/src/test/java/io/trino/execution/TestEventListenerWithSplits.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ public void testSplitsForNormalQuery()
assertEquals(statistics.getPhysicalInputRows(), expectedCompletedPositions);
assertEquals(statistics.getProcessedInputBytes(), 0);
assertEquals(statistics.getProcessedInputRows(), expectedCompletedPositions);
assertEquals(statistics.getInternalNetworkBytes(), 381);
assertEquals(statistics.getInternalNetworkBytes(), 261);
assertEquals(statistics.getInternalNetworkRows(), 3);
assertEquals(statistics.getTotalBytes(), 0);
assertEquals(statistics.getOutputBytes(), 9);
Expand Down