Merged
Conversation
elonazoulay
force-pushed
the
pinot_12
branch
2 times, most recently
from
c111772 to
bc53c7a
Compare
electrum
approved these changes
Mar 19, 2023
Member
electrum
left a comment
electrum
left a comment
There was a problem hiding this comment.
The documentation says we support "Pinot 0.10.0 or higher". Is that still true after this change?
Member
There was a problem hiding this comment.
Did you mean to use == for comparing TransformFunctionType? Does it not implement equality and we need to use identity?
Member
Author
There was a problem hiding this comment.
It's an enum, is that ok?
...rino-pinot/src/main/java/io/trino/plugin/pinot/query/PinotTransformFunctionTypeResolver.java
Outdated
Show resolved
Hide resolved
ebyhr
approved these changes
Mar 19, 2023
plugin/trino-pinot/src/main/java/io/trino/plugin/pinot/query/PinotExpressionRewriter.java
Outdated
Show resolved
Hide resolved
.../trino-pinot/src/test/java/io/trino/plugin/pinot/BasePinotIntegrationConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
elonazoulay
force-pushed
the
pinot_12
branch
2 times, most recently
from
0cd07a5 to
86d2a88
Compare
Member
Author
Updated, thanks for catching that! |
ebyhr
reviewed
Mar 20, 2023
...rino-pinot/src/main/java/io/trino/plugin/pinot/query/PinotTransformFunctionTypeResolver.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upgrade pinot libraries to the latest version.
Release notes
(x) This is not user-visible or docs only and no release notes are required.