Skip to content

Add clean up for DeltaLake ANALYZE tests #16590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ebyhr merged 1 commit into from
Mar 17, 2023
Merged

Add clean up for DeltaLake ANALYZE tests #16590

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeAnalyze.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,8 @@ private void testAnalyze(Optional<Integer> checkpointInterval)
"('comment', 5571.0, 50.0, 0.0, null, null, null)," +
"('name', 531.0, 50.0, 0.0, null, null, null)," +
"(null, null, null, null, 75.0, null, null)");

assertUpdate("DROP TABLE " + tableName);
}

@Test
Expand Down Expand Up @@ -191,6 +193,8 @@ public void testAnalyzePartitioned()
"('comment', 5571.0, 50.0, 0.0, null, null, null)," +
"('name', 531.0, 50.0, 0.0, null, null, null)," +
"(null, null, null, null, 75.0, null, null)");

assertUpdate("DROP TABLE " + tableName);
}

@Test
Expand Down Expand Up @@ -232,6 +236,8 @@ public void testAnalyzeEmpty()
"('comment', 1857.0, 25.0, 0.0, null, null, null)," +
"('name', 177.0, 25.0, 0.0, null, null, null)," +
"(null, null, null, null, 25.0, null, null)");

assertUpdate("DROP TABLE " + tableName);
}

@Test
Expand All @@ -249,6 +255,8 @@ public void testAnalyzeExtendedStatisticsDisabled()
extendedStatisticsDisabled,
"ANALYZE " + tableName,
"ANALYZE not supported if extended statistics are disabled. Enable via delta.extended-statistics.enabled config property or extended_statistics_enabled session property.");

assertUpdate("DROP TABLE " + tableName);
}

@Test
Expand Down Expand Up @@ -284,6 +292,8 @@ public void testAnalyzeWithFilesModifiedAfter()
"('comment', 434.0, 5.0, 0.0, null, null, null)," +
"('name', 33.0, 5.0, 0.0, null, null, null)," +
"(null, null, null, null, 30.0, null, null)");

assertUpdate("DROP TABLE " + tableName);
}

@Test
Expand Down Expand Up @@ -381,6 +391,8 @@ public void testAnalyzeSomeColumns()
"('comment', null, null, 0.0, null, null, null)," +
"('name', null, null, 0.0, null, null, null)," +
"(null, null, null, null, 50.0, null, null)");

assertUpdate("DROP TABLE " + tableName);
}

@Test
Expand Down Expand Up @@ -501,6 +513,8 @@ public void testCreateTableStatisticsWhenCollectionOnWriteDisabled()
"('comment', 1857.0, 25.0, 0.0, null, null, null)," +
"('name', 177.0, 25.0, 0.0, null, null, null)," +
"(null, null, null, null, 25.0, null, null)");

assertUpdate("DROP TABLE " + tableName);
}

@Test
Expand Down Expand Up @@ -535,6 +549,8 @@ public void testCreatePartitionedTableStatisticsWhenCollectionOnWriteDisabled()
"('comment', 1857.0, 25.0, 0.0, null, null, null)," +
"('name', 177.0, 25.0, 0.0, null, null, null)," +
"(null, null, null, null, 25.0, null, null)");

assertUpdate("DROP TABLE " + tableName);
}

@Test
Expand Down Expand Up @@ -565,6 +581,8 @@ public void testStatisticsOnInsertWhenStatsNotCollectedBefore()
"('comment', 1.0, 1.0, 0.0, null, null, null)," +
"('name', 1.0, 1.0, 0.0, null, null, null)," +
"(null, null, null, null, 26.0, null, null)");

assertUpdate("DROP TABLE " + tableName);
}

@Test
Expand Down Expand Up @@ -608,6 +626,8 @@ public void testStatisticsOnInsertWhenCollectionOnWriteDisabled()
"('comment', 3714.0, 50.0, 0.0, null, null, null)," +
"('name', 354.0, 50.0, 0.0, null, null, null)," +
"(null, null, null, null, 50.0, null, null)");

assertUpdate("DROP TABLE " + tableName);
}

@Test
Expand Down Expand Up @@ -655,6 +675,8 @@ public void testPartitionedStatisticsOnInsertWhenCollectionOnWriteDisabled()
"('comment', 3714.0, 50.0, 0.0, null, null, null)," +
"('name', 354.0, 50.0, 0.0, null, null, null)," +
"(null, null, null, null, 50.0, null, null)");

assertUpdate("DROP TABLE " + tableName);
}

@Test
Expand Down Expand Up @@ -693,6 +715,8 @@ public void testIncrementalStatisticsUpdateOnInsert()
"('comment', 5571.0, 50.0, 0.0, null, null, null)," +
"('name', 531.0, 50.0, 0.0, null, null, null)," +
"(null, null, null, null, 75.0, null, null)");

assertUpdate("DROP TABLE " + tableName);
}

private static Session disableStatisticsCollectionOnWrite(Session session)
Expand Down