Restore skip archive handler in Iceberg Glue catalog#16564
Merged
Conversation
electrum
approved these changes
Mar 15, 2023
Member
There was a problem hiding this comment.
buildConfigObject() is intended for conditional configuration of the injector. In this case, we don't need it at binding time, so it's cleaner to use a provider method, just like any other object that we need manually construct based on injected things:
@Provides
@Singleton
@ForGlueHiveMetastore
public static RequestHandler2 createRequestHandler(IcebergGlueCatalogConfig config)
{
return new SkipArchiveRequestHandler(config.isSkipArchive());
}While using buildConfigObject() works fine, it feels like a "trick" or "cheat" that doesn't generalize to other situations. If we needed anything else from the injector to construct the instance, it wouldn't work.
ce42133 broke a logic to skip archive in Iceberg Glue catalog.
b741388 to
209ac9d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #16561
Release notes
(x) This is not user-visible or docs only and no release notes are required.