Skip to content

Don't enforce top-level repo name in BaseCostBasedPlanTest #16486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
findepi merged 1 commit into from
Mar 11, 2023
Merged

Don't enforce top-level repo name in BaseCostBasedPlanTest #16486

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions testing/trino-tests/src/test/java/io/trino/sql/planner/BaseCostBasedPlanTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,15 +221,14 @@ protected Path getSourcePath()
{
Path workingDir = Paths.get(System.getProperty("user.dir"));
verify(isDirectory(workingDir), "Working directory is not a directory");
String topDirectoryName = workingDir.getFileName().toString();
switch (topDirectoryName) {
case "trino-tests":
return workingDir;
case "trino":
return workingDir.resolve("testing/trino-tests");
default:
throw new IllegalStateException("This class must be executed from trino-tests or Trino source directory");
if (isDirectory(workingDir.resolve(".git"))) {
Copy link
Member

@raunaqmorarka raunaqmorarka Mar 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should check for existence of .gitignore file instead since that is part of the checked out source.

Copy link
Member Author

@findepi findepi Mar 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can have .gitignore at any level within the repo, but .git folder should be only one

// Top-level of the repo
return workingDir.resolve("testing/trino-tests");
}
if (workingDir.getFileName().toString().equals("trino-tests")) {
return workingDir;
}
throw new IllegalStateException("This class must be executed from trino-tests or Trino source directory");
}

private class JoinOrderPrinter
Expand Down