Extract meaningful methods in join operator#16468
Merged
sopel39 merged 2 commits intotrinodb:masterfrom Mar 10, 2023
Merged
Conversation
added 2 commits
March 9, 2023 10:43
JFR profiling will also be easier when code is split into more methods
Member
Author
Just for the record, it was your idea in the first place. |
sopel39
approved these changes
Mar 10, 2023
Member
sopel39
left a comment
sopel39
left a comment
There was a problem hiding this comment.
Could this have perf impact? Did JMH change?
| // look for an empty slot or a slot containing this key | ||
| while (keys[pos] != -1) { | ||
| int currentKey = keys[pos]; | ||
| if (hash == positionToHashes[currentKey] && positionEqualsPositionIgnoreNulls(currentKey, realPosition)) { |
Member
Author
There was a problem hiding this comment.
hash is now casted in method invocation, line 122
skrzypo987
commented
Mar 10, 2023
Member
Author
skrzypo987
left a comment
skrzypo987
left a comment
There was a problem hiding this comment.
Could this have perf impact? Did JMH change?
It's quite improbable, for two reasons:
- Those methods are inlined by JIT, if applicable
- Every extracted method either operates on batch of values or performs multiple random memory accesses. So the methods are not cheap and cost of invocation is negligible.
| // look for an empty slot or a slot containing this key | ||
| while (keys[pos] != -1) { | ||
| int currentKey = keys[pos]; | ||
| if (hash == positionToHashes[currentKey] && positionEqualsPositionIgnoreNulls(currentKey, realPosition)) { |
Member
Author
There was a problem hiding this comment.
hash is now casted in method invocation, line 122
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Just a simple refactoring
Additional context and related issues
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: