[FIX] Coerce NullLiteral to boolean in UnwrapCastInComparison#16444
Merged
martint merged 1 commit intotrinodb:masterfrom Mar 8, 2023
gaurav8297:gaurav8297/fix_predicate_pushdown_null_literal
Merged
[FIX] Coerce NullLiteral to boolean in UnwrapCastInComparison#16444martint merged 1 commit intotrinodb:masterfrom gaurav8297:gaurav8297/fix_predicate_pushdown_null_literal
martint merged 1 commit intotrinodb:masterfrom
gaurav8297:gaurav8297/fix_predicate_pushdown_null_literal
Conversation
martint
reviewed
Mar 8, 2023
core/trino-main/src/main/java/io/trino/sql/planner/iterative/rule/UnwrapCastInComparison.java
Outdated
Show resolved
Hide resolved
martint
approved these changes
Mar 8, 2023
Coerce NullLiteral to boolean type otherwise predicate pushdown rule could throw an error while creating FilterNode with NullLiteral as a predicate. This is because FilterNode cannot be created with just NullLiteral without proper coercions.
Member
|
I found a much simple reproduction. @gaurav8297, would you mind putting up a PR to replace the existing test with this? WITH t(a) AS (
VALUES 'a', 'b'
)
SELECT *
FROM t t1 JOIN t t2 ON true
WHERE t1.a = 'aa'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coerce
NullLiteralto boolean type inUnwrapCastInComparisonotherwisePredicatePushDownrule could throw an error while creatingFilterNodewithNullLiteralas a predicate. This is becauseFilterNodecannot be created with justNullLiteralwithout proper coercions.Steps to reproduce the issue in the current version:
Error:
Query 20230308_141912_00008_fy4xb failed: Predicate must be an expression of boolean type: nullDescription
Additional context and related issues
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: