-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Update supported file formats #16424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There is a failure in docs suite. Can you PTAL ? |
|
Unrelated to the docs change but looks like something to investigate: |
|
Ping me to chat about this @Jessie212 |
8640043 to
e631d57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The existing LDAP documentation matches the other places in the documentation that configure keystore/truststore. If we want to explain PEM and JKS, that should be done in a central place. We might already have that and simply need a link from here.
e631d57 to
3b79da7
Compare
colebow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if we're good on the technical content.
|
Seems like the CI failure is a false alarm. |
|
@Jessie212 can you check if similar keystore and truststore properties also need that sort of link added as @electrum suggested? |
mosabua
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now. Thanks.
Description
This change updates property descriptions and examples with supported file formats for password authentication.
Additional context and related issues
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: