Allow reading TimeLogicalTypeAnnotation as BIGINT in parquet#16362
Merged
raunaqmorarka merged 1 commit intotrinodb:masterfrom Mar 4, 2023
Merged
Allow reading TimeLogicalTypeAnnotation as BIGINT in parquet#16362raunaqmorarka merged 1 commit intotrinodb:masterfrom
raunaqmorarka merged 1 commit intotrinodb:masterfrom
Conversation
skrzypo987
approved these changes
Mar 3, 2023
sopel39
approved these changes
Mar 3, 2023
raunaqmorarka
force-pushed
the
pqr-time-bigint
branch
from
d1f5175 to
6291b79
Compare
Reading a parquet column annotated with TimeLogicalTypeAnnotation as a BIGINT type is allowed by Apache Hive. Parquet files with such a type can be produced by Airbyte.
raunaqmorarka
force-pushed
the
pqr-time-bigint
branch
from
6291b79 to
9e9b987
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reading a parquet column annotated with TimeLogicalTypeAnnotation as a BIGINT type is allowed by Apache Hive.
Parquet files with such a type can be produced by Airbyte.
Additional context and related issues
Since only the iceberg connector in trino supports time(6) and it cannot directly start working with raw parquet files without usage of outside tools, there is a significant impediment to working with parquet files produced from airbyte containing time type right now.
https://trinodb.slack.com/archives/CGB0QHWSW/p1677680804930869
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text: