Update Ignite getTableProperties implementation#16359
Merged
ebyhr merged 1 commit intotrinodb:masterfrom Mar 6, 2023
chenjian2664:ignite_op_tableproperties
Merged
Update Ignite getTableProperties implementation#16359ebyhr merged 1 commit intotrinodb:masterfrom chenjian2664:ignite_op_tableproperties
ebyhr merged 1 commit intotrinodb:masterfrom
chenjian2664:ignite_op_tableproperties
Conversation
ebyhr
reviewed
Mar 3, 2023
Contributor
Author
|
Yes support, switched to use |
chenjian2664
changed the title
ebyhr
requested changes
Mar 3, 2023
plugin/trino-ignite/src/main/java/io/trino/plugin/ignite/IgniteClient.java
Outdated
Show resolved
Hide resolved
ebyhr
approved these changes
Mar 6, 2023
Member
ebyhr
left a comment
ebyhr
left a comment
There was a problem hiding this comment.
Could you leave the motivation to the commit body?
plugin/trino-ignite/src/main/java/io/trino/plugin/ignite/IgniteClient.java
Outdated
Show resolved
Hide resolved
ebyhr
reviewed
Mar 6, 2023
plugin/trino-ignite/src/main/java/io/trino/plugin/ignite/IgniteClient.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update Ignite table properties raw sql, we can get the primary key directly from sys.indexes.
Additional context and related issues
Release notes
(x) This is not user-visible or docs only and no release notes are required.