Remove reference to AST in RefreshMaterializedViewReference#16348
Merged
martint merged 1 commit intotrinodb:masterfrom Mar 6, 2023
Merged
Remove reference to AST in RefreshMaterializedViewReference#16348martint merged 1 commit intotrinodb:masterfrom
martint merged 1 commit intotrinodb:masterfrom
Conversation
kokosing
reviewed
Mar 3, 2023
| extends WriterTarget | ||
| { | ||
| private final Table table; | ||
| private final String table; |
Member
There was a problem hiding this comment.
I think we should name this variable tableToStringRepresentation to stress that it is only used for toString() method. Otherwise one could try to use it to something else in future.
Another idea is to remove this field completely and maybe use TableHandle in toString()
Member
There was a problem hiding this comment.
I think it's obvious that a raw name shouldn't be used for something else. Do you have something in mind where this would be used and the author wouldn't quickly discover that it's wrong?
electrum
approved these changes
Mar 5, 2023
kokosing
approved these changes
Mar 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes
(x) This is not user-visible or docs only and no release notes are required.