Skip to content

Add TestAddColumnTask and TestDropColumnTask#16324

Merged
ebyhr merged 1 commit intotrinodb:masterfrom
ebyhr:ebi/core-test-add-column-task
Mar 7, 2023
Merged

Add TestAddColumnTask and TestDropColumnTask#16324
ebyhr merged 1 commit intotrinodb:masterfrom
ebyhr:ebi/core-test-add-column-task

Conversation

@ebyhr
Copy link
Copy Markdown
Member

@ebyhr ebyhr commented Mar 1, 2023

Description

Fixes #16320

Release notes

(x) This is not user-visible or docs only and no release notes are required.

@ebyhr ebyhr self-assigned this Mar 1, 2023
@cla-bot cla-bot bot added the cla-signed label Mar 1, 2023
@ebyhr
Copy link
Copy Markdown
Member Author

ebyhr commented Mar 2, 2023

CI hit #16277

@ebyhr ebyhr requested review from Praveen2112 and findepi March 6, 2023 00:47
Comment thread core/trino-main/src/test/java/io/trino/execution/TestAddColumnTask.java Outdated
Comment thread core/trino-main/src/test/java/io/trino/execution/TestAddColumnTask.java Outdated
Comment thread core/trino-main/src/test/java/io/trino/execution/TestDropColumnTask.java Outdated
Comment thread core/trino-main/src/test/java/io/trino/execution/TestDropColumnTask.java Outdated
Comment thread core/trino-main/src/test/java/io/trino/execution/TestDropColumnTask.java Outdated
Comment thread core/trino-main/src/test/java/io/trino/execution/TestDropColumnTask.java Outdated
Comment thread core/trino-main/src/test/java/io/trino/execution/TestDropColumnTask.java Outdated
@ebyhr ebyhr force-pushed the ebi/core-test-add-column-task branch from 05dc9b5 to 6876310 Compare March 6, 2023 07:28
@ebyhr
Copy link
Copy Markdown
Member Author

ebyhr commented Mar 6, 2023

@Praveen2112 Thanks for your review. Addressed comments.

@ebyhr ebyhr requested a review from Praveen2112 March 7, 2023 02:47
Copy link
Copy Markdown
Member

@Praveen2112 Praveen2112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. % comments.

Comment thread core/trino-main/src/test/java/io/trino/execution/TestAddColumnTask.java Outdated
Comment thread core/trino-main/src/test/java/io/trino/execution/TestAddColumnTask.java Outdated
Comment thread core/trino-main/src/test/java/io/trino/execution/TestAddColumnTask.java Outdated
Comment thread core/trino-main/src/test/java/io/trino/execution/TestDropColumnTask.java Outdated
Comment thread core/trino-main/src/test/java/io/trino/execution/TestDropColumnTask.java Outdated
Comment thread core/trino-main/src/test/java/io/trino/execution/TestDropColumnTask.java Outdated
@ebyhr ebyhr force-pushed the ebi/core-test-add-column-task branch from 6876310 to d1ecec0 Compare March 7, 2023 06:50
@ebyhr ebyhr merged commit 4bc10da into trinodb:master Mar 7, 2023
@ebyhr ebyhr deleted the ebi/core-test-add-column-task branch March 7, 2023 08:39
@github-actions github-actions bot added this to the 410 milestone Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Add TestAddColumnTask and TestDropColumnTask

2 participants