Merged
Conversation
Member
dain
commented
Oct 1, 2019
dain
commented
- Change OrcReader to produce Page
- Add type safe wrappers for ORC identifiers
- Rename ORC stream classes to column
dain
force-pushed
the
orc-read-api-cleanup
branch
from
a386bce to
922cca1
Compare
dain
force-pushed
the
orc-read-api-cleanup
branch
from
922cca1 to
afa513b
Compare
phd3
reviewed
Oct 12, 2019
Member
phd3
left a comment
phd3
left a comment
There was a problem hiding this comment.
Thanks for simplifying this! :)
some nit comments, still reading a few classes.
presto-hive/src/main/java/io/prestosql/plugin/hive/HiveSessionProperties.java
Outdated
Show resolved
Hide resolved
presto-orc/src/main/java/io/prestosql/orc/reader/BooleanColumnReader.java
Outdated
Show resolved
Hide resolved
presto-orc/src/main/java/io/prestosql/orc/metadata/OrcMetadataWriter.java
Outdated
Show resolved
Hide resolved
presto-orc/src/main/java/io/prestosql/orc/checkpoint/Checkpoints.java
Outdated
Show resolved
Hide resolved
dain
force-pushed
the
orc-read-api-cleanup
branch
from
afa513b to
156dfab
Compare
phd3
reviewed
Oct 14, 2019
Member
phd3
left a comment
phd3
left a comment
There was a problem hiding this comment.
I think that OrcRecordReader#blockLoaded can incur double/multiple counting for nested block sizes. For a column C with type row(a, b, c), getLoadedBlock invocation for column C will result in ORCRecordReader#blockLoaded 4 times, right? getSizeInBytes for a C includes sizes of fieldBlocks as well. so the internal block sizes would be counted twice.
presto-hive/src/main/java/io/prestosql/plugin/hive/orc/OrcPageSource.java
Outdated
Show resolved
Hide resolved
presto-hive/src/main/java/io/prestosql/plugin/hive/orc/OrcPageSourceFactory.java
Outdated
Show resolved
Hide resolved
electrum
approved these changes
Oct 17, 2019
presto-orc/src/main/java/io/prestosql/orc/checkpoint/Checkpoints.java
Outdated
Show resolved
Hide resolved
presto-hive/src/main/java/io/prestosql/plugin/hive/orc/OrcPageSource.java
Outdated
Show resolved
Hide resolved
presto-hive/src/main/java/io/prestosql/plugin/hive/orc/OrcPageSource.java
Outdated
Show resolved
Hide resolved
presto-hive/src/main/java/io/prestosql/plugin/hive/orc/OrcPageSourceFactory.java
Outdated
Show resolved
Hide resolved
presto-hive/src/main/java/io/prestosql/plugin/hive/orc/OrcPageSourceFactory.java
Outdated
Show resolved
Hide resolved
...raptor-legacy/src/main/java/io/prestosql/plugin/raptor/legacy/storage/OrcStorageManager.java
Outdated
Show resolved
Hide resolved
presto-orc/src/main/java/io/prestosql/orc/metadata/ColumnMetadata.java
Outdated
Show resolved
Hide resolved
presto-orc/src/main/java/io/prestosql/orc/metadata/ColumnMetadata.java
Outdated
Show resolved
Hide resolved
presto-orc/src/main/java/io/prestosql/orc/OrcWriteValidation.java
Outdated
Show resolved
Hide resolved
presto-orc/src/main/java/io/prestosql/orc/metadata/OrcMetadataWriter.java
Outdated
Show resolved
Hide resolved
dain
force-pushed
the
orc-read-api-cleanup
branch
from
156dfab to
8e91dea
Compare
zhenxiao
pushed a commit
to prestodb/presto
that referenced
this pull request
Jul 15, 2021
Cherry-pick of trinodb/trino#1067, trinodb/trino#2042, trinodb/trino#4055, trinodb/trino#1629, trinodb/trino#3483 Co-authored-by: Parth Brahmbhatt <pbrahmbhatt@netflix.com> Co-authored-by: David Phillips <david@acz.org> Co-authored-by: Xingyuan Lin <linxingyuan1102@gmail.com> Co-authored-by: Dain Sundstrom <dain@iq80.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.