Added jdbc fetch size config for pg/oracle/redshift#16269
Added jdbc fetch size config for pg/oracle/redshift#16269chenjian2664 wants to merge 1 commit intotrinodb:masterfrom chenjian2664:add_fetch_size_pg
Conversation
|
Mark, we need add log. |
|
Under what circumstances would someone want to change the fetch size? |
Hi, I saw a user shared experience in #16153.
I think most of cases it's works fine, but we can not cover all the user cases for sure. In this PR only allow some connectors set the default fetch size, and still put default value same as originally. |
If we don't understand when someone would want to set the new toggle, we would be able to document it properly. This would result in a feature that's used by very few users, which generally isn't good. If we understand when someone would want to set the new toggle, then maybe we do not need a toggle at all. Ideally Trino would make right decisions out of the box, which would result in a feature that works for every user, which generally is good. |
|
Hello! |
|
Thanks @findepi 's sharing
Honestly, Trino is pretty good for most of the users in the out of the box point, but default config is not always the best in any scenarios, so 'performance tuning' is always a endless topic. |
|
I think this will definitely improve the performance in some cases. Today I was trying to pull 3 columns from oracle and it's really slow. I think increasing the fetch size in these scenarios will definitely boost the performance. |
|
@subbareddydagumati thanks for your feedback. |
|
Will close this at this moment. |
Description
Solve #16153
Removed the magic number
1000in the pg/oracle/redshift client.Added
jdbc-fetch-sizeconfiguration for pg/oracle/redshift connector.Additional context and related issues
Release notes
( ) This is not user-visible or docs only and no release notes are required.
(x) Release notes are required, please propose a release note for me.
() Release notes are required, with the following suggested text: