Update TestingPhoenixServer using SharedResource

[chenjian2664]

Description

Update TestingPhoenixServer using SharedResource

Additional context and related issues

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

[kokosing]

Nice!

[findepi]

What's the benefit of this change?

[chenjian2664]

What's the benefit of this change?

Improve code readability, users know to get a "Lease" from a "shared resource" instead of a new instance. Any concern from your side?

[findepi]

io.trino.testing.SharedResource#returnLease does reference counting and triggers shutdown.
this is good when resource can be re-creater relatively cheaply, but obviously may lead to a resource being created multiple times, perhaps once for each test class.

What's the TestingPhoenixServer startup time?

[chenjian2664]

Take TestingPhoenixServer for instance, returnLease is similar to the previous shutdown action, and the timing of the current call is also similar to afterClass as before. IMO there is no additional overhead for creating and closing resources compared to the previous implementation, correct me if I am wrong.

It is true that the creation of TestingPhoenixServer is time-consuming, we may be able to:

• Implement a function similar to closeAfterClass in TestingPhoenixServer, without actively returning Lease return TestingPhoenixServer instead.
• We can rewrite the Close method without actually closing the server, and then actively close the Lease when we want to close it.
• A bit of a hack way :), obtain the Lease somewhere in advance, and then actively close the Lease when we want to close it.

What do you think

[kokosing]

SharedResource#returnLease does reference counting and triggers shutdown.

I am under impression that previous implementation did exactly the same.